]> granicus.if.org Git - fortune-mod/log
fortune-mod
3 years agoprepare for a release v2.29.x-devel-branch--with-docbook-docs fortune-mod-3.0.0
Shlomi Fish [Wed, 16 Sep 2020 10:53:01 +0000 (13:53 +0300)]
prepare for a release

3 years agoadd a quote
Shlomi Fish [Wed, 16 Sep 2020 10:36:54 +0000 (13:36 +0300)]
add a quote

3 years agoadd the reddit/"is cheating" quote
Shlomi Fish [Wed, 16 Sep 2020 10:24:47 +0000 (13:24 +0300)]
add the reddit/"is cheating" quote

3 years agoappveyor tweak #1: disable cache (it is slow)
Shlomi Fish [Wed, 16 Sep 2020 10:03:45 +0000 (13:03 +0300)]
appveyor tweak #1: disable cache (it is slow)

3 years agosilence signed comparison warning.
Shlomi Fish [Wed, 16 Sep 2020 10:02:41 +0000 (13:02 +0300)]
silence signed comparison warning.

3 years agoappveyor fix #5: syntax
Shlomi Fish [Wed, 16 Sep 2020 09:52:48 +0000 (12:52 +0300)]
appveyor fix #5: syntax

3 years agoappveyor fix #4: syntax
Shlomi Fish [Wed, 16 Sep 2020 09:39:50 +0000 (12:39 +0300)]
appveyor fix #4: syntax

3 years agoappveyor fix #3: syntax
Shlomi Fish [Wed, 16 Sep 2020 09:33:50 +0000 (12:33 +0300)]
appveyor fix #3: syntax

3 years agoappveyor fix cleanup #2: check for strawberryperl
Shlomi Fish [Wed, 16 Sep 2020 09:32:41 +0000 (12:32 +0300)]
appveyor fix cleanup #2: check for strawberryperl

3 years agoappveyor fix #1: avoid strawberryperl install
Shlomi Fish [Wed, 16 Sep 2020 09:19:18 +0000 (12:19 +0300)]
appveyor fix #1: avoid strawberryperl install

3 years agoadd credits
Shlomi Fish [Tue, 15 Sep 2020 16:21:58 +0000 (19:21 +0300)]
add credits

3 years agotravis: upgrade dist
Shlomi Fish [Tue, 15 Sep 2020 15:53:48 +0000 (18:53 +0300)]
travis: upgrade dist

3 years agorename to a nicer name
Shlomi Fish [Tue, 15 Sep 2020 15:50:19 +0000 (18:50 +0300)]
rename to a nicer name

3 years agoadd const
Shlomi Fish [Tue, 15 Sep 2020 15:37:27 +0000 (18:37 +0300)]
add const

3 years agoAvoid double negative+remove us of non-POSIX regexes
Shlomi Fish [Tue, 15 Sep 2020 15:30:34 +0000 (18:30 +0300)]
Avoid double negative+remove us of non-POSIX regexes

3 years agorefactoring: merge some duplicate code
Shlomi Fish [Sun, 30 Aug 2020 11:17:55 +0000 (14:17 +0300)]
refactoring: merge some duplicate code

3 years agoprepare for the new release fortune-mod-2.29.1
Shlomi Fish [Sun, 30 Aug 2020 06:39:04 +0000 (09:39 +0300)]
prepare for the new release

3 years agofix some C compiler warnings when not using lib-recode
Shlomi Fish [Mon, 24 Aug 2020 17:59:44 +0000 (20:59 +0300)]
fix some C compiler warnings when not using lib-recode

3 years agofix some C compiler warnings on windows
Shlomi Fish [Mon, 24 Aug 2020 17:54:40 +0000 (20:54 +0300)]
fix some C compiler warnings on windows

3 years agoappveyor fix #5: fix CR line ends tests on mswin
Shlomi Fish [Mon, 24 Aug 2020 17:38:47 +0000 (20:38 +0300)]
appveyor fix #5: fix CR line ends tests on mswin

3 years agoappveyor fix #4: docbook xsltproc cygwin path hack
Shlomi Fish [Mon, 24 Aug 2020 17:18:29 +0000 (20:18 +0300)]
appveyor fix #4: docbook xsltproc cygwin path hack

3 years agoappveyor fix #3: missing docbook deps
Shlomi Fish [Mon, 24 Aug 2020 16:59:11 +0000 (19:59 +0300)]
appveyor fix #3: missing docbook deps

3 years agoappveyor fix #2: missing docmake deps
Shlomi Fish [Mon, 24 Aug 2020 16:21:52 +0000 (19:21 +0300)]
appveyor fix #2: missing docmake deps

3 years agoappveyor fix #1: better windows/etc. compat
Shlomi Fish [Mon, 24 Aug 2020 16:07:36 +0000 (19:07 +0300)]
appveyor fix #1: better windows/etc. compat

3 years agoprepare for the 2.29.0-dev release fortune-mod-2.29.0
Shlomi Fish [Thu, 20 Aug 2020 12:49:48 +0000 (15:49 +0300)]
prepare for the 2.29.0-dev release

3 years agoConvert more manpages to DocBook 5 XML. try-to-use-a-better-format-than-nroff
Shlomi Fish [Tue, 18 Aug 2020 12:10:17 +0000 (15:10 +0300)]
Convert more manpages to DocBook 5 XML.

Remove unused nroff-generating program and update gitignore.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agorefactoring
Shlomi Fish [Tue, 18 Aug 2020 12:06:38 +0000 (15:06 +0300)]
refactoring

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Tue, 18 Aug 2020 12:02:39 +0000 (15:02 +0300)]
Convert more manpages to DocBook 5 XML.

post process the directory names.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Tue, 18 Aug 2020 11:42:58 +0000 (14:42 +0300)]
Convert more manpages to DocBook 5 XML.

CMake / named SGML entities / etc.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Tue, 18 Aug 2020 11:10:50 +0000 (14:10 +0300)]
Convert more manpages to DocBook 5 XML.

cmake generating code.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Tue, 18 Aug 2020 10:34:02 +0000 (13:34 +0300)]
Convert more manpages to DocBook 5 XML.

The fortune(1) one in its two versions.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoremove files that appear to not be used
Shlomi Fish [Tue, 18 Aug 2020 06:40:10 +0000 (09:40 +0300)]
remove files that appear to not be used

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Sat, 15 Aug 2020 16:39:57 +0000 (19:39 +0300)]
Convert more manpages to DocBook 5 XML.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Sat, 15 Aug 2020 16:34:40 +0000 (19:34 +0300)]
Convert more manpages to DocBook 5 XML.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Sat, 15 Aug 2020 16:31:52 +0000 (19:31 +0300)]
Convert more manpages to DocBook 5 XML.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agofix regex match
Shlomi Fish [Sat, 15 Aug 2020 16:18:37 +0000 (19:18 +0300)]
fix regex match

3 years agoConvert more manpages to DocBook 5 XML.
Shlomi Fish [Sat, 15 Aug 2020 15:44:15 +0000 (18:44 +0300)]
Convert more manpages to DocBook 5 XML.

See:

* https://github.com/shlomif/fortune-mod/issues/41

Made use of doclifter ( http://www.catb.org/~esr/doclifter/ ),
docmake ( https://www.shlomifish.org/open-source/projects/docmake/ ),
cmake, and Perl 5. Thanks!

The current plan is to provide the resultant nroff outputs (or easily 's/.../.../'able
templates of them) inside the source tarballs to avoid a build time dependency on
DocBook XSL and docmake.

3 years agoExtract a method or a function.
Shlomi Fish [Sat, 15 Aug 2020 15:13:30 +0000 (18:13 +0300)]
Extract a method or a function.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

3 years agorefactor: remove unused imports
Shlomi Fish [Sat, 15 Aug 2020 13:36:57 +0000 (16:36 +0300)]
refactor: remove unused imports

3 years agotravis-fix #1: docmake/docbook
Shlomi Fish [Sat, 15 Aug 2020 12:58:33 +0000 (15:58 +0300)]
travis-fix #1: docmake/docbook

3 years agoFix build and tests' dependencies/trail-space/etc.
Shlomi Fish [Sat, 15 Aug 2020 11:53:33 +0000 (14:53 +0300)]
Fix build and tests' dependencies/trail-space/etc.

3 years agofix the build - stale cmake vars
Shlomi Fish [Sat, 15 Aug 2020 11:40:25 +0000 (14:40 +0300)]
fix the build - stale cmake vars

3 years agotry to fix nroff man markup
Shlomi Fish [Sat, 15 Aug 2020 11:19:45 +0000 (14:19 +0300)]
try to fix nroff man markup

3 years agoavoid regenerating symlink targets [cmake]
Shlomi Fish [Sat, 15 Aug 2020 11:32:34 +0000 (14:32 +0300)]
avoid regenerating symlink targets [cmake]

3 years agoadd docbook5 ver using doclifter. "docmake manpages" renders it wrong
Shlomi Fish [Sat, 15 Aug 2020 10:13:40 +0000 (13:13 +0300)]
add docbook5 ver using doclifter. "docmake manpages" renders it wrong

3 years agoCorrect the attribution of a saying.
Shlomi Fish [Tue, 11 Aug 2020 13:43:54 +0000 (16:43 +0300)]
Correct the attribution of a saying.

3 years agoCorrect plural tense of "cliches"
Shlomi Fish [Fri, 17 Jul 2020 05:05:13 +0000 (08:05 +0300)]
Correct plural tense of "cliches"

3 years agoremove pointless leading space/indent in paradoxum
Shlomi Fish [Tue, 30 Jun 2020 09:04:10 +0000 (12:04 +0300)]
remove pointless leading space/indent in paradoxum

3 years agoprepare for new release fortune-mod-2.28.0
Shlomi Fish [Tue, 2 Jun 2020 18:20:27 +0000 (21:20 +0300)]
prepare for new release

3 years agoUpdate literature
Tobin Yehle [Fri, 22 May 2020 19:30:05 +0000 (12:30 -0700)]
Update literature

Fix a Shakespeare attribution. There is no Henry VI part IV. See https://en.wikipedia.org/wiki/Let%27s_kill_all_the_lawyers

4 years agoadd more credits
Shlomi Fish [Tue, 12 May 2020 08:46:24 +0000 (11:46 +0300)]
add more credits

4 years agoadd credits
Shlomi Fish [Tue, 12 May 2020 08:42:28 +0000 (11:42 +0300)]
add credits

4 years agoAdd more done tasks.
Shlomi Fish [Tue, 12 May 2020 08:32:35 +0000 (11:32 +0300)]
Add more done tasks.

4 years agocorrect a typo - "Jonny Quest"
Shlomi Fish [Sun, 3 May 2020 07:01:06 +0000 (10:01 +0300)]
correct a typo - "Jonny Quest"

4 years agoprefix
Shlomi Fish [Sat, 2 May 2020 10:30:53 +0000 (13:30 +0300)]
prefix

4 years agocheck for overflow
Shlomi Fish [Sat, 2 May 2020 10:23:57 +0000 (13:23 +0300)]
check for overflow

4 years agoconvert to bool
Shlomi Fish [Sat, 2 May 2020 10:14:07 +0000 (13:14 +0300)]
convert to bool

4 years agoprepare for new release fortune-mod-2.26.0
Shlomi Fish [Sat, 2 May 2020 08:04:30 +0000 (11:04 +0300)]
prepare for new release

4 years agoDetect an integer overflow when handling prcnts.
Shlomi Fish [Fri, 1 May 2020 16:18:35 +0000 (19:18 +0300)]
Detect an integer overflow when handling prcnts.

[SECURITY]

Thanks to a code review done by a facebook friend.

4 years ago*printf format strings revamp - minor security change
Shlomi Fish [Fri, 1 May 2020 11:23:45 +0000 (14:23 +0300)]
*printf format strings revamp - minor security change

4 years agoRequire snprintf() without detection.
Shlomi Fish [Fri, 1 May 2020 10:24:28 +0000 (13:24 +0300)]
Require snprintf() without detection.

It is C99.

4 years agoreplace sprintf with snprintf - minor security change
Shlomi Fish [Fri, 1 May 2020 10:17:51 +0000 (13:17 +0300)]
replace sprintf with snprintf -  minor security change

4 years agoprepare for the new release fortune-mod-2.24.0
Shlomi Fish [Thu, 30 Apr 2020 08:06:26 +0000 (11:06 +0300)]
prepare for the new release

4 years agodetect snprintf
Shlomi Fish [Thu, 30 Apr 2020 08:01:38 +0000 (11:01 +0300)]
detect snprintf

4 years agorefactoringgot rid of == NULL
Shlomi Fish [Thu, 30 Apr 2020 07:24:25 +0000 (10:24 +0300)]
refactoringgot rid of == NULL

4 years agoExtract a common module/library/header.
Shlomi Fish [Thu, 30 Apr 2020 07:05:32 +0000 (10:05 +0300)]
Extract a common module/library/header.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoExtract a method or a function.
Shlomi Fish [Thu, 30 Apr 2020 06:46:56 +0000 (09:46 +0300)]
Extract a method or a function.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoExtract a method or a function.
Shlomi Fish [Thu, 30 Apr 2020 06:37:39 +0000 (09:37 +0300)]
Extract a method or a function.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoSome minor fixes from OpenBSD's fortune sources.
Shlomi Fish [Thu, 30 Apr 2020 06:19:19 +0000 (09:19 +0300)]
Some minor fixes from OpenBSD's fortune sources.

Thanks!

4 years agolicense an original file better
Shlomi Fish [Wed, 29 Apr 2020 20:56:40 +0000 (23:56 +0300)]
license an original file better

4 years agoadd a regression test for an overflow
Shlomi Fish [Wed, 29 Apr 2020 20:52:51 +0000 (23:52 +0300)]
add a regression test for an overflow

4 years agoadd a regression test for an overflow
Shlomi Fish [Wed, 29 Apr 2020 20:35:59 +0000 (23:35 +0300)]
add a regression test for an overflow

4 years agoAdd a regression test for the buffer overflow.
Shlomi Fish [Wed, 29 Apr 2020 20:30:49 +0000 (23:30 +0300)]
Add a regression test for the buffer overflow.

4 years agoprepare for the new release fortune-mod-2.22.0
Shlomi Fish [Wed, 29 Apr 2020 12:57:59 +0000 (15:57 +0300)]
prepare for the new release

4 years agosilence warnings on !WITH_RECODE.
Shlomi Fish [Wed, 29 Apr 2020 12:57:14 +0000 (15:57 +0300)]
silence warnings on !WITH_RECODE.

Thanks to appveyor.

4 years agorefactoring
Shlomi Fish [Wed, 29 Apr 2020 12:36:33 +0000 (15:36 +0300)]
refactoring

4 years agoRefactoring / code cleanup.
Shlomi Fish [Wed, 29 Apr 2020 12:31:53 +0000 (15:31 +0300)]
Refactoring / code cleanup.

* https://en.wikipedia.org/wiki/Code_refactoring

Some small optimisations may have slipped in as well.

do_free is simply free; copy() was underused.

4 years agoRefactoring / code cleanup.
Shlomi Fish [Wed, 29 Apr 2020 12:19:38 +0000 (15:19 +0300)]
Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoupdate the file "cookie-files"
Shlomi Fish [Wed, 29 Apr 2020 12:12:39 +0000 (15:12 +0300)]
update the file "cookie-files"

4 years agoExtract a common expression into a variable/const.
Shlomi Fish [Wed, 29 Apr 2020 11:42:29 +0000 (14:42 +0300)]
Extract a common expression into a variable/const.

This is Refactoring / code cleanup.

See:

* https://refactoring.com/catalog/extractMethod.html

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoremove unused and disabled code
Shlomi Fish [Wed, 29 Apr 2020 11:34:45 +0000 (14:34 +0300)]
remove unused and disabled code

4 years agocorrect typo.
Shlomi Fish [Wed, 29 Apr 2020 11:33:51 +0000 (14:33 +0300)]
correct typo.

4 years agoRename variable/s to make them more descriptive.
Shlomi Fish [Wed, 29 Apr 2020 11:27:54 +0000 (14:27 +0300)]
Rename variable/s to make them more descriptive.

4 years agorefactoring + security: avoid overflow
Shlomi Fish [Wed, 29 Apr 2020 11:22:14 +0000 (14:22 +0300)]
refactoring + security: avoid overflow

4 years agosecurity: avoid overflow
Shlomi Fish [Wed, 29 Apr 2020 11:14:28 +0000 (14:14 +0300)]
security: avoid overflow

4 years agoSilence compile-time or run-time warnings.
Shlomi Fish [Wed, 29 Apr 2020 10:50:58 +0000 (13:50 +0300)]
Silence compile-time or run-time warnings.

See:

* https://duckduckgo.com/?q=warnings+programming&atb=v140-1&ia=web

They are a distraction at best and may indicate other issues.

4 years agorefactoring: was always true
Shlomi Fish [Wed, 29 Apr 2020 10:49:09 +0000 (13:49 +0300)]
refactoring: was always true

4 years agorefactoring: merge cmake install targets
Shlomi Fish [Wed, 29 Apr 2020 10:23:25 +0000 (13:23 +0300)]
refactoring: merge cmake install targets

4 years agoRefactoring / code cleanup.
Shlomi Fish [Wed, 29 Apr 2020 10:20:37 +0000 (13:20 +0300)]
Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

4 years agoremove or rename old man pages.
Shlomi Fish [Wed, 29 Apr 2020 10:01:51 +0000 (13:01 +0300)]
remove or rename old man pages.

To avoid cluttering the source dirs.

4 years agorefactoring
Shlomi Fish [Wed, 29 Apr 2020 09:35:14 +0000 (12:35 +0300)]
refactoring

4 years agorename vars
Shlomi Fish [Wed, 29 Apr 2020 09:11:03 +0000 (12:11 +0300)]
rename vars

4 years agotravis+appveyor cleanups
Shlomi Fish [Wed, 29 Apr 2020 09:05:03 +0000 (12:05 +0300)]
travis+appveyor cleanups

4 years agoadd cache to travis cpan modules
Shlomi Fish [Wed, 29 Apr 2020 08:53:41 +0000 (11:53 +0300)]
add cache to travis cpan modules

4 years agoavoid predecls
Shlomi Fish [Wed, 29 Apr 2020 08:46:24 +0000 (11:46 +0300)]
avoid predecls

4 years agoRename variable/s to make them more descriptive.
Shlomi Fish [Wed, 29 Apr 2020 08:43:00 +0000 (11:43 +0300)]
Rename variable/s to make them more descriptive.

4 years agoAvoid predeclaring variables and localize their decl.
Shlomi Fish [Wed, 29 Apr 2020 08:32:07 +0000 (11:32 +0300)]
Avoid predeclaring variables and localize their decl.

See:

* http://perl-begin.org/tutorials/bad-elements/#declaring_all_vars_at_top

* https://en.wikipedia.org/wiki/Perl_Best_Practices

4 years agoAvoid predeclaring variables and localize their decl.
Shlomi Fish [Wed, 29 Apr 2020 08:30:11 +0000 (11:30 +0300)]
Avoid predeclaring variables and localize their decl.

See:

* http://perl-begin.org/tutorials/bad-elements/#declaring_all_vars_at_top

* https://en.wikipedia.org/wiki/Perl_Best_Practices

4 years agoadd braces
Shlomi Fish [Wed, 29 Apr 2020 08:20:26 +0000 (11:20 +0300)]
add braces

4 years agorefactoring
Shlomi Fish [Wed, 29 Apr 2020 08:11:49 +0000 (11:11 +0300)]
refactoring