Tag HEAD of 2.4.x as 2.4.38

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/tags/2.4.38@1851569 13f79535-47bb-0310-9956-ffa450edef68

Get ready to tag httpd 2.4.38

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851568 13f79535-47bb-0310-9956-ffa450edef68

Revert invalid 2.4.28/38 tagging.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851567 13f79535-47bb-0310-9956-ffa450edef68

Fix errant lines added by script

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851561 13f79535-47bb-0310-9956-ffa450edef68

Post 2.4.38 tag updates

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851559 13f79535-47bb-0310-9956-ffa450edef68

Tag HEAD of 2.4.x as 2.4.38

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/tags/2.4.38@1851558 13f79535-47bb-0310-9956-ffa450edef68

Get ready to tag httpd 2.4.38

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851557 13f79535-47bb-0310-9956-ffa450edef68

Applied in r1851526

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851556 13f79535-47bb-0310-9956-ffa450edef68

Carry ylavic's vote forward to mod_md fix

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851555 13f79535-47bb-0310-9956-ffa450edef68

Per jorton's feedback, clarify in comments. Any objections?

Any clue why this alerted on valgrind and apr_authz_dbm did not?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851554 13f79535-47bb-0310-9956-ffa450edef68

Post 2.4.28 tag updates

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851550 13f79535-47bb-0310-9956-ffa450edef68

Get ready to tag httpd 2.4.28

[Reverted by r1851567]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851548 13f79535-47bb-0310-9956-ffa450edef68

Merge non-vetoed bit.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851527 13f79535-47bb-0310-9956-ffa450edef68

Merge r1850834 from trunk:

* modules/md/md_acme_drive.c (acme_driver_init):
  Remove written-but-not-read variable (gcc 8.x warning).

Submitted by: jorton
Reviewed by: jailletc36, jim, ylavic

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851526 13f79535-47bb-0310-9956-ffa450edef68

Promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851515 13f79535-47bb-0310-9956-ffa450edef68

Votes.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851514 13f79535-47bb-0310-9956-ffa450edef68

Merge of r1830747 from trunk:

mod_md: Don't export all symbols on Unix (reduces .so size by ~8%) [jorton]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851511 13f79535-47bb-0310-9956-ffa450edef68

vote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851510 13f79535-47bb-0310-9956-ffa450edef68

Since jim insists upon a single proposal, nix it all.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851485 13f79535-47bb-0310-9956-ffa450edef68

this format has been used a crapton of times. Not sure why this time there's an issue.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851484 13f79535-47bb-0310-9956-ffa450edef68

Ask for cleaner backport submissions, if you could?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851475 13f79535-47bb-0310-9956-ffa450edef68

mod_ssl (ssl_engine_io.c: bio_filter_out_write, bio_filter_in_read)
Clear retry flags before aborting on client-initiated reneg.

PR: 63052
Backports: r1850946
Submitted by: Joe Orton
Reviewed by: wrowe, jorton, rpluem

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851471 13f79535-47bb-0310-9956-ffa450edef68

mod_negotiation: LanguagePriority tags must be treated case-insensitive,
per https://tools.ietf.org/html/rfc7231#section-3.1.3.1

PR: 39730
Backports: r1850989
Submitted by: jailletc36
Reviewed by: jailletc36, wrowe, jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851468 13f79535-47bb-0310-9956-ffa450edef68

Offer one more alternative

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851415 13f79535-47bb-0310-9956-ffa450edef68

mod_session: Always decode session attributes early.

Backport r1850947 from trunk
Submitted by: hwibell
Reviewed by: hwibell, covener, wrowe

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851409 13f79535-47bb-0310-9956-ffa450edef68

Asked and answered. Appears correct to me, would appreciate Stefan's vote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851401 13f79535-47bb-0310-9956-ffa450edef68

backport votes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851370 13f79535-47bb-0310-9956-ffa450edef68

you take the good, you take the bad -- the facts of life.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851354 13f79535-47bb-0310-9956-ffa450edef68

* Vote and promote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851345 13f79535-47bb-0310-9956-ffa450edef68

note mod_lua is now marked stable.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851342 13f79535-47bb-0310-9956-ffa450edef68

mod_lua moved to stable; https://s.apache.org/Xnh1

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851341 13f79535-47bb-0310-9956-ffa450edef68

Merge of r1846125 from trunk:

mod_http2: change in cleanup strategy for slave connections.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851329 13f79535-47bb-0310-9956-ffa450edef68

Vote/note.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851328 13f79535-47bb-0310-9956-ffa450edef68

Note PR63052 bugfix

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851311 13f79535-47bb-0310-9956-ffa450edef68

Some upvotes for 'ready' state, and clarify some of my other feedback.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851297 13f79535-47bb-0310-9956-ffa450edef68

Clarify requirement

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851289 13f79535-47bb-0310-9956-ffa450edef68

Votes/observations

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851286 13f79535-47bb-0310-9956-ffa450edef68

fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851176 13f79535-47bb-0310-9956-ffa450edef68

XML fr doc update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851175 13f79535-47bb-0310-9956-ffa450edef68

Typo.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851174 13f79535-47bb-0310-9956-ffa450edef68

Remove the default CacheKeyBaseURL value, it doesn't have any.
Improve syntax highlight and hyper-links.
(r1851152 in trunk)

s/authorisation/authorization/ to be consitent
(r1516864 in trunk)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851155 13f79535-47bb-0310-9956-ffa450edef68

Fix a typo (r1851100 in trunk) + a few random synch with trunk

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851101 13f79535-47bb-0310-9956-ffa450edef68

Propose

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851096 13f79535-47bb-0310-9956-ffa450edef68

vote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850973 13f79535-47bb-0310-9956-ffa450edef68

Propose

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850968 13f79535-47bb-0310-9956-ffa450edef68

Propose maintainer-mode fix backport

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850746 13f79535-47bb-0310-9956-ffa450edef68

Fix some broken links already fixed in trunk. (incorrect module names in <directive>)

Synch a bit with trunk

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850684 13f79535-47bb-0310-9956-ffa450edef68

Add compatibility note
(r1850545 in trunk)

+ fix a typo to synch with trunk

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850547 13f79535-47bb-0310-9956-ffa450edef68

Add new modules to the list of the 2.4 new features list
(r1850545 in trunk)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850546 13f79535-47bb-0310-9956-ffa450edef68

Add compatibility note as already noted in new_features_2_4.xml
(r1850539 in trunk)

+ remove a trailing space to synch with trunk

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850541 13f79535-47bb-0310-9956-ffa450edef68

Docs rebuild after copyright year update.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850126 13f79535-47bb-0310-9956-ffa450edef68

Happy New Year 2019

Backport of r1850098 from trunk.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1850100 13f79535-47bb-0310-9956-ffa450edef68

Unwise?

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1849326 13f79535-47bb-0310-9956-ffa450edef68

backport vote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1849303 13f79535-47bb-0310-9956-ffa450edef68

Merge of r1849174 from trunk:

  *) mod_md: incorrect behaviour when synchronizing ongoing ACME challenges
     have been fixed. [Michael Kaufmann, Stefan Eissing]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1849176 13f79535-47bb-0310-9956-ffa450edef68

Give credit to the author.

I only tested, added a test case and proposed for backport.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848980 13f79535-47bb-0310-9956-ffa450edef68

Merge r1848236 from trunk:

core: Fix incorrect substitution of env vars in directives containing multiple env vars.

In ap_resolve_env(), the string returned from getenv() should be copied since
the returned string may be statically allocated.

This fixes an issue where the value for the last env var is substituted for all
env vars in a directive containing multiple env vars.

Submitted by: hwibell
Reviewed by: hwibell, covener, jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848686 13f79535-47bb-0310-9956-ffa450edef68

Merge r1830816, r1830836, r1842882, r1842884 from trunk:

* modules/ssl: Add some missing logno tags.

* modules/ssl/ssl_engine_pphrase.c (ssl_load_encrypted_pkey):
  Simplify code, no functional change.

* modules/slotmem/mod_slotmem_shm.c (restore_slotmem): Remove
  redundant assignment (clang warning), the apr_file_eof(fp)=>APR_EOF
  case assigns rv to APR_EOF and then to APR_SUCCESS after already.

* modules/mappers/mod_negotiation.c (set_language_quality): Remove
  redundant branch (warning from Coverity).

Submitted by: jorton
Reviewed by: jailletc36, icing, jorton, jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848685 13f79535-47bb-0310-9956-ffa450edef68

Merge r1831773 from trunk:

PR62311: only create the rewritelock when needed

Submitted By: Hank Ibell <hwibell gmail.com>
Committed By: covener

Submitted by: covener
Reviewed by: jailletc36, icing (by inspection), covener

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848681 13f79535-47bb-0310-9956-ffa450edef68

promote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848680 13f79535-47bb-0310-9956-ffa450edef68

some tested backports

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848679 13f79535-47bb-0310-9956-ffa450edef68

Nominate*1.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848395 13f79535-47bb-0310-9956-ffa450edef68

Propose conn/req hostname fix

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848256 13f79535-47bb-0310-9956-ffa450edef68

quick votes, promote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848255 13f79535-47bb-0310-9956-ffa450edef68

Propose

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1848239 13f79535-47bb-0310-9956-ffa450edef68

votes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847457 13f79535-47bb-0310-9956-ffa450edef68

Propose.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847432 13f79535-47bb-0310-9956-ffa450edef68

*) mod_setenvif: We can have expressions that become true if a regex pattern
   in the expression does NOT match. In this case val is NULL
   and we should just set the value for the environment variable
   like in the pattern case.
+1: jailletc36, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847292 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847291 13f79535-47bb-0310-9956-ffa450edef68

*) mod_dav: Fix invalid Location header when a resource is created by passing
   an absolute URI on the request line
+1: jailletc36, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847290 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847289 13f79535-47bb-0310-9956-ffa450edef68

*) mod_session_cookie: avoid duplicate Set-Cookie headers in the response.
   trunk patch: http://svn.apache.org/r1843244
+1: elukey, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847288 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847287 13f79535-47bb-0310-9956-ffa450edef68

*) event MPM: Don't log "at MaxRequestWorkers" when there are still idle threads,
   just like worker.
+1: covener, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847286 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847285 13f79535-47bb-0310-9956-ffa450edef68

*) mod_ssl: Fixes PR 62654 where "require ssl" did not work on HTTP/2
   connections, and PR 61519 where $HTTPS was incorrect for the
   "SSLEngine optional" case.
+1: jorton, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847284 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847283 13f79535-47bb-0310-9956-ffa450edef68

mod_ssl: Fixes PR 62880 where certificate loading fails bc SSL ERRs are
         not cleared beforehand.
+1: icing, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847280 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847279 13f79535-47bb-0310-9956-ffa450edef68

mod_ssl: Fix the error code returned in an error path of 'ssl_io_filter_handshake()'
This messes-up error handling performed in 'ssl_io_filter_error()'
+1: ylavic, jim, minfrin

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847278 13f79535-47bb-0310-9956-ffa450edef68

Vote and promote.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1847277 13f79535-47bb-0310-9956-ffa450edef68

* Add a comment

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846375 13f79535-47bb-0310-9956-ffa450edef68

Propose

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846341 13f79535-47bb-0310-9956-ffa450edef68

backport votes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846306 13f79535-47bb-0310-9956-ffa450edef68

Add PR reference.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846255 13f79535-47bb-0310-9956-ffa450edef68

r1846112 is a bit too tomcatty, counter-proposal...

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846218 13f79535-47bb-0310-9956-ffa450edef68

backport propoosal

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846126 13f79535-47bb-0310-9956-ffa450edef68

backport proposal

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846115 13f79535-47bb-0310-9956-ffa450edef68

removing unwanted file change

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846114 13f79535-47bb-0310-9956-ffa450edef68

backport proposal

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846113 13f79535-47bb-0310-9956-ffa450edef68

Merge r1837250 from trunk:

If ProxyPassReverse is used for reverse mapping of relative redirects, subsequent ProxyPassReverse statements, whether they are relative or absolute, may fail.

PR 60408 [Peter Haworth <pmh1wheel gmail.com>]
Submitted by: jailletc36
Reviewed by: jailletc36, rpluem, jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846044 13f79535-47bb-0310-9956-ffa450edef68

promote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846043 13f79535-47bb-0310-9956-ffa450edef68

Backport votes

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1846042 13f79535-47bb-0310-9956-ffa450edef68

Propose backport of fix to PR 62880.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1845769 13f79535-47bb-0310-9956-ffa450edef68

* Vote

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1845267 13f79535-47bb-0310-9956-ffa450edef68

Propose

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1845125 13f79535-47bb-0310-9956-ffa450edef68

fr doc rebuild.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1844962 13f79535-47bb-0310-9956-ffa450edef68

XML updates.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1844961 13f79535-47bb-0310-9956-ffa450edef68

Propose.

Tested with a highly modified dav.t which sends raw commands on a sock + wireshark to check the result.
(I've not found an easy way to force HTTP::DAV to use absolute URI)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1844908 13f79535-47bb-0310-9956-ffa450edef68

Updates for announcement of 2.4.37

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1844645 13f79535-47bb-0310-9956-ffa450edef68