From ffd72acc508bbc994812cefbfb9532d3be2ab737 Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Tue, 5 Jun 2018 06:50:56 -0700 Subject: [PATCH] bpo-33752: Fix a file leak in test_dbm. (GH-7376) With addCleanup() f.close() was executed after tearDown(). (cherry picked from commit 6592d7fe11477f8f974d2d4a85c3382a1ad05217) Co-authored-by: Serhiy Storchaka --- Lib/test/test_dbm.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_dbm.py b/Lib/test/test_dbm.py index 78c32c4c93..1884b5c683 100644 --- a/Lib/test/test_dbm.py +++ b/Lib/test/test_dbm.py @@ -75,10 +75,8 @@ class AnyDBMTestCase: def test_anydbm_creation_n_file_exists_with_invalid_contents(self): # create an empty file test.support.create_empty_file(_fname) - - f = dbm.open(_fname, 'n') - self.addCleanup(f.close) - self.assertEqual(len(f), 0) + with dbm.open(_fname, 'n') as f: + self.assertEqual(len(f), 0) def test_anydbm_modification(self): self.init_db() -- 2.40.0