From ff57ecd981437c9cedf06d600ccf647c0e628d57 Mon Sep 17 00:00:00 2001 From: Kees Monshouwer Date: Fri, 4 May 2018 11:03:17 +0200 Subject: [PATCH] auth-bindbackend: only compare ips in isMaster() --- modules/bindbackend/bindbackend2.cc | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/modules/bindbackend/bindbackend2.cc b/modules/bindbackend/bindbackend2.cc index 86159c424..3dea35d3a 100644 --- a/modules/bindbackend/bindbackend2.cc +++ b/modules/bindbackend/bindbackend2.cc @@ -1211,10 +1211,16 @@ bool Bind2Backend::isMaster(const DNSName& name, const string &ip) if(bbd.d_kind != DomainInfo::Slave) return false; - for(vector::const_iterator iter = bbd.d_masters.begin(); iter != bbd.d_masters.end(); ++iter) - if(*iter==ip) - return true; - + for(vector::const_iterator iter = bbd.d_masters.begin(); iter != bbd.d_masters.end(); ++iter) { + try { + const ComboAddress caMaster(*iter); + if(ip == caMaster.toString()) { + return true; + } + } + catch(...) {} + } + return false; } -- 2.40.0