From feb16c84dcdea64bc32a8bb903ccd325fdf12b67 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 11 Nov 2016 22:09:25 +0000 Subject: [PATCH] Simplify code and address review comments (NFC) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286644 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/GlobalMerge.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/CodeGen/GlobalMerge.cpp b/lib/CodeGen/GlobalMerge.cpp index c3d49c035a4..1ea53493994 100644 --- a/lib/CodeGen/GlobalMerge.cpp +++ b/lib/CodeGen/GlobalMerge.cpp @@ -425,7 +425,6 @@ bool GlobalMerge::doMerge(const SmallVectorImpl &Globals, DEBUG(dbgs() << " Trying to merge set, starts with #" << GlobalSet.find_first() << "\n"); - StringRef ExternalName; ssize_t i = GlobalSet.find_first(); while (i != -1) { ssize_t j = 0; @@ -434,6 +433,7 @@ bool GlobalMerge::doMerge(const SmallVectorImpl &Globals, std::vector Inits; bool HasExternal = false; + StringRef FirstExternalName; for (j = i; j != -1; j = GlobalSet.find_next(j)) { Type *Ty = Globals[j]->getValueType(); MergedSize += DL.getTypeAllocSize(Ty); @@ -445,8 +445,7 @@ bool GlobalMerge::doMerge(const SmallVectorImpl &Globals, if (Globals[j]->hasExternalLinkage() && !HasExternal) { HasExternal = true; - auto *TheFirstExternal = Globals[j]; - ExternalName = TheFirstExternal->getName(); + FirstExternalName = Globals[j]->getName(); } } @@ -466,7 +465,7 @@ bool GlobalMerge::doMerge(const SmallVectorImpl &Globals, // _MergedGlobals symbols. Twine MergedName = (IsMachO && HasExternal) - ? "_MergedGlobals_" + ExternalName + ? "_MergedGlobals_" + FirstExternalName : "_MergedGlobals"; auto MergedLinkage = IsMachO ? Linkage : GlobalValue::PrivateLinkage; auto *MergedGV = new GlobalVariable( -- 2.50.1