From fd5b2ce150185d8d8fc3d7789983bbd2b0b8103f Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Wed, 4 Jun 2008 20:48:08 +0000 Subject: [PATCH] Added fixmes. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51964 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExprObjC.cpp | 2 ++ test/Sema/objc-comptypes-9.m | 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 108ff3c21e..d833efe309 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -339,6 +339,8 @@ static bool ClassImplementsProtocol(ObjCProtocolDecl *lProto, // In gcc, it is also allowed assigning a protocol-qualified 'id' // type to a LHS object when protocol in qualified LHS is in list // of protocols in the rhs 'id' object. This IMO, should be a bug. + // FIXME: Treat this as an extension, and flag this as an error when + // GCC extensions are not enabled. else if (RHSIsQualifiedID && ProtocolCompatibleWithProtocol(protoList[i], lProto)) return true; diff --git a/test/Sema/objc-comptypes-9.m b/test/Sema/objc-comptypes-9.m index 0358fc39d0..4f0a277e74 100644 --- a/test/Sema/objc-comptypes-9.m +++ b/test/Sema/objc-comptypes-9.m @@ -1,4 +1,6 @@ // RUN: clang -fsyntax-only %s +// FIXME: This test case tests the patch applied in: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080602/006017.html +// Eventually that logic should be treated as an extension. typedef signed char BOOL; typedef int NSInteger; -- 2.50.1