From fcadea2556be268121a6216e367bbe3598c4008e Mon Sep 17 00:00:00 2001 From: John McCall Date: Thu, 12 Aug 2010 00:57:17 +0000 Subject: [PATCH] Fix a crash on invalid when declaring an implicit member of a class with an invalid destructor. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@110891 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDecl.cpp | 8 +++++++- test/SemaCXX/destructor.cpp | 14 ++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index de7ad3d791..b27f727b3c 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -3652,8 +3652,14 @@ void Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, bool &Redeclaration, bool &OverloadableAttrRequired) { // If NewFD is already known erroneous, don't do any of this checking. - if (NewFD->isInvalidDecl()) + if (NewFD->isInvalidDecl()) { + // If this is a class member, mark the class invalid immediately. + // This avoids some consistency errors later. + if (isa(NewFD)) + cast(NewFD)->getParent()->setInvalidDecl(); + return; + } if (NewFD->getResultType()->isVariablyModifiedType()) { // Functions returning a variably modified type violate C99 6.7.5.2p2 diff --git a/test/SemaCXX/destructor.cpp b/test/SemaCXX/destructor.cpp index 1502f73471..cdcae2e411 100644 --- a/test/SemaCXX/destructor.cpp +++ b/test/SemaCXX/destructor.cpp @@ -105,3 +105,17 @@ namespace test6 { class B : A { B(); }; B::B() {} // expected-note {{in instantiation of member function 'test6::A::~A' requested here}} } + +// Make sure classes are marked invalid when they have invalid +// members. This avoids a crash-on-invalid. +namespace test7 { + struct A { + ~A() const; // expected-error {{'const' qualifier is not allowed on a destructor}} + }; + struct B : A {}; + + void test() { + B *b; + b->~B(); + } +} -- 2.40.0