From fbe1bd55b5d286975203d07b79547c3f807cc9a2 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Fri, 24 Sep 2021 19:30:37 -0700 Subject: [PATCH] lefty: abbreviate some boolean returns in 'orderop' --- cmd/lefty/aix_mods/exec.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/cmd/lefty/aix_mods/exec.c b/cmd/lefty/aix_mods/exec.c index 80152ca03..32556e9e2 100644 --- a/cmd/lefty/aix_mods/exec.c +++ b/cmd/lefty/aix_mods/exec.c @@ -822,9 +822,7 @@ static int orderop(Tobj v1o, Ctype_t op, Tobj v2o) double d1, d2; if (!v1o || !v2o) { - if ((v1o || v2o) && op == C_NE) - return TRUE; - return FALSE; + return (v1o || v2o) && op == C_NE; } t1 = Tgettype(v1o), t2 = Tgettype(v2o); if (t1 == T_STRING && t2 == T_STRING) { @@ -850,17 +848,17 @@ static int orderop(Tobj v1o, Ctype_t op, Tobj v2o) } switch (op) { case C_EQ: - return (r == 0) ? TRUE : FALSE; + return r == 0; case C_NE: - return (r != 0) ? TRUE : FALSE; + return r != 0; case C_LT: - return (r < 0) ? TRUE : FALSE; + return r < 0; case C_LE: - return (r <= 0) ? TRUE : FALSE; + return r <= 0; case C_GT: - return (r > 0) ? TRUE : FALSE; + return r > 0; case C_GE: - return (r >= 0) ? TRUE : FALSE; + return r >= 0; } panic1(POS, "orderop", "bad op code"); return FALSE; /* NOT REACHED */ -- 2.40.0