From fbda75de8597dd5beb1b3a6eedddceab13c432aa Mon Sep 17 00:00:00 2001 From: Eric Liu Date: Thu, 11 Oct 2018 17:50:04 +0000 Subject: [PATCH] Revert "[Lex] TokenConcatenation now takes const Preprocessor" This reverts commit r344262. This was an unintentional commit. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@344267 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../Checkers/UninitializedObject/UninitializedObject.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h b/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h index 828955dc10..d10b862ea0 100644 --- a/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h +++ b/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h @@ -79,9 +79,9 @@ class FieldNode { protected: const FieldRegion *FR; - // TODO: This destructor shouldn't be virtual, but breaks buildbots with - // -Werror -Wnon-virtual-dtor. - virtual ~FieldNode() = default; + /// FieldNodes are never meant to be created on the heap, see + /// FindUninitializedFields::addFieldToUninits(). + /* non-virtual */ ~FieldNode() = default; public: FieldNode(const FieldRegion *FR) : FR(FR) {} -- 2.40.0