From fba9e8f85b3043da0e045cd653bcba9b6c60e067 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 25 Jun 2010 00:05:45 +0000 Subject: [PATCH] Add comment for my last patch. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@106813 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDecl.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index 5c1de6aeb8..ba84f7c223 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -1454,7 +1454,13 @@ void Sema::MergeVarDecl(VarDecl *New, LookupResult &Previous) { New->setInvalidDecl(); return; } - + // c99 6.2.2 P4. + // For an identifier declared with the storage-class specifier extern in a + // scope in which a prior declaration of that identifier is visible, if + // the prior declaration specifies internal or external linkage, the linkage + // of the identifier at the later declaration is the same as the linkage + // specified at the prior declaration. + // FIXME. revisit this code. if (New->hasExternalStorage() && Old->getLinkage() == InternalLinkage && New->getDeclContext() == Old->getDeclContext()) -- 2.40.0