From faeb1ac77af665b5c4f5b6f06c4f267cb498073c Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Tue, 21 Mar 2017 18:26:18 +0000 Subject: [PATCH] Modules: Remove an invalid check in unit tests for r298278 This is a fixup for the unit tests from r298278 (originally r298165). Since the buffer that RawB2 pointed at was later deleted, a new call to getBuffer may very well return a buffer at the same/old address. Which is fine. Just delete the spurious check. A Windows bot was occasionally hitting this in practice: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7086 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@298414 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/Basic/MemoryBufferCacheTest.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/unittests/Basic/MemoryBufferCacheTest.cpp b/unittests/Basic/MemoryBufferCacheTest.cpp index e7d61e3ac9..99178f8150 100644 --- a/unittests/Basic/MemoryBufferCacheTest.cpp +++ b/unittests/Basic/MemoryBufferCacheTest.cpp @@ -50,7 +50,6 @@ TEST(MemoryBufferCacheTest, addBuffer) { // Replace the middle buffer. B2 = getBuffer(2); - ASSERT_NE(RawB2, B2.get()); RawB2 = B2.get(); EXPECT_EQ(RawB2, &Cache.addBuffer("2", std::move(B2))); -- 2.40.0