From f89c6352f5364b016b0d49ef8fbe1a223d072b27 Mon Sep 17 00:00:00 2001 From: Magnus Jacobsson Date: Sat, 1 Jan 2022 18:01:01 +0100 Subject: [PATCH] dot: MSBuild: define GVDLL to ensure correct storage-class attributes An upcoming commit will change the storage-class attributes to be controlled by the GVDLL symbol in cgraph.h. Without this change, errors like this would occur: dot.obj : error LNK2001: unresolved external symbol _Agdirected Towards https://gitlab.com/graphviz/graphviz/-/issues/2173. --- cmd/dot/dot.vcxproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/dot/dot.vcxproj b/cmd/dot/dot.vcxproj index 475051b4e..9517acb27 100644 --- a/cmd/dot/dot.vcxproj +++ b/cmd/dot/dot.vcxproj @@ -52,7 +52,7 @@ Disabled $(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories) - _DEBUG;_CONSOLE;WIN32_DLL;DEMAND_LOADING;%(PreprocessorDefinitions) + _DEBUG;_CONSOLE;GVDLL;WIN32_DLL;DEMAND_LOADING;%(PreprocessorDefinitions) EnableFastChecks MultiThreadedDebugDLL @@ -83,7 +83,7 @@ copy /B /Y $(OutDir)dot.exe $(OutDir)twopi.exe $(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories) - NDEBUG;_CONSOLE;WIN32_DLL;DEMAND_LOADING;%(PreprocessorDefinitions) + NDEBUG;_CONSOLE;GVDLL;WIN32_DLL;DEMAND_LOADING;%(PreprocessorDefinitions) Level4 true -- 2.40.0