From f73a486408a0f95221135103df37a1513c51700d Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Thu, 26 Jan 2017 00:42:42 +0000 Subject: [PATCH] [NewGVN] Skip uses in unreachable blocks. Otherwise we ask for a domtree node that's not there, and we crash. Differential Revision: https://reviews.llvm.org/D29145 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293122 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/NewGVN.cpp | 6 +++++ test/Transforms/NewGVN/pr31758.ll | 37 +++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 test/Transforms/NewGVN/pr31758.ll diff --git a/lib/Transforms/Scalar/NewGVN.cpp b/lib/Transforms/Scalar/NewGVN.cpp index fe5a43872f5..747c913278f 100644 --- a/lib/Transforms/Scalar/NewGVN.cpp +++ b/lib/Transforms/Scalar/NewGVN.cpp @@ -1936,6 +1936,12 @@ void NewGVN::convertDenseToDFSOrdered( IBlock = I->getParent(); VD.LocalNum = InstrDFS.lookup(I); } + + // Skip uses in unreachable blocks, as we're going + // to delete them. + if (ReachableBlocks.count(IBlock) == 0) + continue; + DomTreeNode *DomNode = DT->getNode(IBlock); VD.DFSIn = DomNode->getDFSNumIn(); VD.DFSOut = DomNode->getDFSNumOut(); diff --git a/test/Transforms/NewGVN/pr31758.ll b/test/Transforms/NewGVN/pr31758.ll new file mode 100644 index 00000000000..ca33299a104 --- /dev/null +++ b/test/Transforms/NewGVN/pr31758.ll @@ -0,0 +1,37 @@ +; RUN: opt -newgvn %s -S -o - | FileCheck %s + +%struct.dipsy = type {} +%struct.fluttershy = type { %struct.dipsy* } +%struct.patatino = type {} + +define void @tinkywinky() { +bb: + br label %bb90 + +bb90: + %tmp = getelementptr inbounds %struct.fluttershy, %struct.fluttershy* undef, i64 0, i32 0 + %tmp91 = bitcast %struct.dipsy** %tmp to %struct.patatino** + %tmp92 = load %struct.patatino*, %struct.patatino** %tmp91, align 8 + %tmp99 = getelementptr inbounds %struct.patatino, %struct.patatino* %tmp92 + %tmp134 = getelementptr inbounds %struct.fluttershy, %struct.fluttershy* undef, i64 0, i32 0 + %tmp135 = bitcast %struct.dipsy** %tmp134 to %struct.patatino** + %tmp136 = load %struct.patatino*, %struct.patatino** %tmp135, align 8 + br label %bb90 + +bb138: + %tmp139 = getelementptr inbounds %struct.patatino, %struct.patatino* %tmp136 + br label %bb138 +} + +; CHECK-LABEL: tinkywinky +; CHECK-NEXT: bb: +; CHECK-NEXT: br label %bb90 +; CHECK-NEXT +; CHECK: bb90: +; CHECK: %tmp91 = bitcast %struct.dipsy** undef to %struct.patatino** +; CHECK-NEXT: %tmp92 = load %struct.patatino*, %struct.patatino** %tmp91, align 8 +; CHECK-NEXT: %tmp136 = load %struct.patatino*, %struct.patatino** %tmp91, align 8 +; CHECK-NEXT: br label %bb90 +; CHECK: bb138: +; CHECK-NEXT: br label %bb138 +; CHECK-NEXT: } -- 2.40.0