From f595a127b82ba34ab0b65979ab28bc77491ba00a Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Sun, 22 Jun 2014 19:33:19 -0700 Subject: [PATCH] Issue #8343: Named group error msgs did not show the group name. --- Lib/sre_parse.py | 9 ++++++--- Misc/NEWS | 3 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/Lib/sre_parse.py b/Lib/sre_parse.py index e37e2cfce3..662e49a187 100644 --- a/Lib/sre_parse.py +++ b/Lib/sre_parse.py @@ -567,7 +567,8 @@ def _parse(source, state): "%r" % name) gid = state.groupdict.get(name) if gid is None: - raise error, "unknown group name" + msg = "unknown group name: {0!r}".format(name) + raise error(msg) subpatternappend((GROUPREF, gid)) continue else: @@ -620,7 +621,8 @@ def _parse(source, state): if isname(condname): condgroup = state.groupdict.get(condname) if condgroup is None: - raise error, "unknown group name" + msg = "unknown group name: {0!r}".format(condgroup) + raise error(msg) else: try: condgroup = int(condname) @@ -746,7 +748,8 @@ def parse_template(source, pattern): try: index = pattern.groupindex[name] except KeyError: - raise IndexError, "unknown group name" + msg = "unknown group name: {0!r}".format(name) + raise IndexError(msg) a((MARK, index)) elif c == "0": if s.next in OCTDIGITS: diff --git a/Misc/NEWS b/Misc/NEWS index aa054039e1..3238d06ec7 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -31,6 +31,9 @@ Library - Issue #21672: Fix the behavior of ntpath.join on UNC-style paths. +- Issue #8343: Named group error messages in the re module did not show + the name of the erroneous group. + - Issue #21491: SocketServer: Fix a race condition in child processes reaping. - Issue #21635: The difflib SequenceMatcher.get_matching_blocks() method -- 2.50.1