From f54e3aec8a12c3ce453b1012e686c4b88881564a Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 8 Oct 2010 22:59:25 +0000 Subject: [PATCH] Method implemented in class's implementation may implement one declared in class's extension and not one declared in class's superclass. This supresses a bogus warning on method type mismatch. Fixes //rdar: // 8530080 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@116118 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDeclObjC.cpp | 9 +++++++++ test/SemaObjC/metod-in-class-extension-impl.m | 20 +++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 test/SemaObjC/metod-in-class-extension-impl.m diff --git a/lib/Sema/SemaDeclObjC.cpp b/lib/Sema/SemaDeclObjC.cpp index 09502a4923..74bd00340c 100644 --- a/lib/Sema/SemaDeclObjC.cpp +++ b/lib/Sema/SemaDeclObjC.cpp @@ -924,7 +924,16 @@ void Sema::MatchAllMethodDeclarations(const llvm::DenseSet &InsMap, WarnConflictingTypedMethods(ImpMethodDecl, IntfMethodDecl); } } + if (ObjCInterfaceDecl *I = dyn_cast (CDecl)) { + // Also methods in class extensions need be looked at next. + for (const ObjCCategoryDecl *ClsExtDecl = I->getFirstClassExtension(); + ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) + MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, + IMPDecl, + const_cast(ClsExtDecl), + IncompleteImpl, false); + // Check for any implementation of a methods declared in protocol. for (ObjCInterfaceDecl::all_protocol_iterator PI = I->all_referenced_protocol_begin(), diff --git a/test/SemaObjC/metod-in-class-extension-impl.m b/test/SemaObjC/metod-in-class-extension-impl.m new file mode 100644 index 0000000000..c205322dec --- /dev/null +++ b/test/SemaObjC/metod-in-class-extension-impl.m @@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s +// rdar://8530080 + +@protocol ViewDelegate @end + +@interface NSTextView +- (id )delegate; +@end + +@interface FooTextView : NSTextView +@end + +@interface FooTextView() +- (id)delegate; +@end + +@implementation FooTextView +- (id)delegate {return 0; } +@end + -- 2.40.0