From f4aac742c8293b1a0535a8133f926d46474300f0 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 26 Sep 2017 15:25:56 -0400 Subject: [PATCH] Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/E1dv9jI-0006oT-Fn@gemulon.postgresql.org --- src/backend/commands/analyze.c | 2 +- src/test/regress/expected/vacuum.out | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index c58f3096e6..79fcb54e3a 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -382,7 +382,7 @@ do_analyze_rel(Relation onerel, int options, VacuumParams *params, if (bms_is_member(i, unique_cols)) ereport(ERROR, (errcode(ERRCODE_DUPLICATE_COLUMN), - errmsg("column \"%s\" of relation \"%s\" is specified twice", + errmsg("column \"%s\" of relation \"%s\" appears more than once", col, RelationGetRelationName(onerel)))); unique_cols = bms_add_member(unique_cols, i); diff --git a/src/test/regress/expected/vacuum.out b/src/test/regress/expected/vacuum.out index 23a877e9cc..540f4f3014 100644 --- a/src/test/regress/expected/vacuum.out +++ b/src/test/regress/expected/vacuum.out @@ -82,8 +82,8 @@ VACUUM FULL vactst; VACUUM (DISABLE_PAGE_SKIPPING) vaccluster; -- check behavior with duplicate column mentions VACUUM ANALYZE vaccluster(i,i); -ERROR: column "i" of relation "vaccluster" is specified twice +ERROR: column "i" of relation "vaccluster" appears more than once ANALYZE vaccluster(i,i); -ERROR: column "i" of relation "vaccluster" is specified twice +ERROR: column "i" of relation "vaccluster" appears more than once DROP TABLE vaccluster; DROP TABLE vactst; -- 2.40.0