From f379121093deb5465b01d93ebe9410d96c6cd093 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 8 Mar 2017 16:10:00 -0500 Subject: [PATCH] Suppress compiler warning in non-USE_LIBXML builds. Compilers that don't realize that ereport(ERROR) doesn't return complained that XmlTableGetValue() failed to return a value. Also, make XmlTableFetchRow's non-USE_LIBXML case look more like the other ones. As coded, it could lead to "unreachable code" warnings with USE_LIBXML enabled. Oversights in commit fcec6caaf. Per buildfarm. --- src/backend/utils/adt/xml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c index 7fd3ec3fae..04aeb7178e 100644 --- a/src/backend/utils/adt/xml.c +++ b/src/backend/utils/adt/xml.c @@ -4389,9 +4389,8 @@ XmlTableFetchRow(TableFuncScanState *state) return false; #else NO_XML_SUPPORT(); -#endif /* not USE_LIBXML */ - return false; +#endif /* not USE_LIBXML */ } /* @@ -4561,6 +4560,7 @@ XmlTableGetValue(TableFuncScanState *state, int colnum, return result; #else NO_XML_SUPPORT(); + return 0; #endif /* not USE_LIBXML */ } -- 2.40.0