From f2af8dc5ba8801c126d877a52076d441cac78646 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 29 Sep 2016 12:00:00 -0400 Subject: [PATCH] Fix compiler warnings This was missed in bf5bb2e85b6492c7245b9446efaf43d52a98db13, because the code is only visible under PG_FLUSH_DATA_WORKS. --- src/common/file_utils.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/common/file_utils.c b/src/common/file_utils.c index 04cd365e76..1d855645b9 100644 --- a/src/common/file_utils.c +++ b/src/common/file_utils.c @@ -30,7 +30,7 @@ #endif #ifdef PG_FLUSH_DATA_WORKS -static void pre_sync_fname(const char *fname, bool isdir, +static int pre_sync_fname(const char *fname, bool isdir, const char *progname); #endif static void walkdir(const char *path, @@ -187,7 +187,7 @@ walkdir(const char *path, */ #ifdef PG_FLUSH_DATA_WORKS -static void +static int pre_sync_fname(const char *fname, bool isdir, const char *progname) { int fd; @@ -197,10 +197,10 @@ pre_sync_fname(const char *fname, bool isdir, const char *progname) if (fd < 0) { if (errno == EACCES || (isdir && errno == EISDIR)) - return; + return 0; fprintf(stderr, _("%s: could not open file \"%s\": %s\n"), progname, fname, strerror(errno)); - return; + return -1; } /* @@ -217,6 +217,7 @@ pre_sync_fname(const char *fname, bool isdir, const char *progname) #endif (void) close(fd); + return 0; } #endif /* PG_FLUSH_DATA_WORKS */ -- 2.40.0