From f28f5f3af488e36cb53b833d67c61414426afd6a Mon Sep 17 00:00:00 2001 From: nekral-guest Date: Fri, 24 Apr 2009 22:22:57 +0000 Subject: [PATCH] * libmisc/mail.c: Ignore the return value of puts(). * libmisc/mail.c: Prefer snprintf to sprintf, even if a small context indicates no issues. --- ChangeLog | 6 ++++++ libmisc/mail.c | 13 +++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 07d1ca6e..589abdd8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-04-25 Nicolas François + + * libmisc/mail.c: Ignore the return value of puts(). + * libmisc/mail.c: Prefer snprintf to sprintf, even if a small + context indicates no issues. + 2009-04-22 Nicolas François * lib/commonio.c, lib/commonio.h, lib/groupio.c, lib/groupio.h, diff --git a/libmisc/mail.c b/libmisc/mail.c index e75032a0..5b70c73c 100644 --- a/libmisc/mail.c +++ b/libmisc/mail.c @@ -57,13 +57,14 @@ void mailcheck (void) mailbox = getenv ("MAILDIR"); if (NULL != mailbox) { char *newmail; + size_t len = strlen (mailbox) + 5; - newmail = xmalloc (strlen (mailbox) + 5); - sprintf (newmail, "%s/new", mailbox); + newmail = xmalloc (len); + snprintf (newmail, len, "%s/new", mailbox); if (stat (newmail, &statbuf) != -1 && statbuf.st_size != 0) { if (statbuf.st_mtime > statbuf.st_atime) { free (newmail); - puts (_("You have new mail.")); + (void) puts (_("You have new mail.")); return; } } @@ -77,11 +78,11 @@ void mailcheck (void) if ( (stat (mailbox, &statbuf) == -1) || (statbuf.st_size == 0)) { - puts (_("No mail.")); + (void) puts (_("No mail.")); } else if (statbuf.st_atime > statbuf.st_mtime) { - puts (_("You have mail.")); + (void) puts (_("You have mail.")); } else { - puts (_("You have new mail.")); + (void) puts (_("You have new mail.")); } } -- 2.40.0