From f19641462b337a790d2824fc5fe2fd2bf8e0464a Mon Sep 17 00:00:00 2001 From: Stefan Fritsch Date: Sat, 13 Aug 2011 09:14:33 +0000 Subject: [PATCH] Compare value instead of string pointer Remove unused label Remove unused var git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1157357 13f79535-47bb-0310-9956-ffa450edef68 --- modules/aaa/mod_authnz_ldap.c | 3 --- modules/ldap/util_ldap.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/modules/aaa/mod_authnz_ldap.c b/modules/aaa/mod_authnz_ldap.c index eba5cbfe45..d32f84f899 100644 --- a/modules/aaa/mod_authnz_ldap.c +++ b/modules/aaa/mod_authnz_ldap.c @@ -451,7 +451,6 @@ static util_ldap_connection_t *get_connection_for_authz(request_rec *r, enum aut static authn_status authn_ldap_check_password(request_rec *r, const char *user, const char *password) { - int failures = 0; char filtbuf[FILTER_LENGTH]; authn_ldap_config_t *sec = (authn_ldap_config_t *)ap_get_module_config(r->per_dir_config, &authnz_ldap_module); @@ -479,8 +478,6 @@ static authn_status authn_ldap_check_password(request_rec *r, const char *user, return AUTH_GENERAL_ERROR; } -start_over: - /* There is a good AuthLDAPURL, right? */ if (sec->host) { const char *binddn = sec->binddn; diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c index 8a27156d4a..e0185949c3 100644 --- a/modules/ldap/util_ldap.c +++ b/modules/ldap/util_ldap.c @@ -2684,7 +2684,7 @@ static const char *util_ldap_set_retries(cmd_parms *cmd, } st->retries = atoi(val); - if (val < 0) { + if (st->retries < 0) { return "LDAPRetries must be >= 0"; } -- 2.40.0