From f170e61d9baf794ec2301b0eed168f3cefbab862 Mon Sep 17 00:00:00 2001 From: Barry Lind Date: Fri, 5 Jul 2002 18:50:27 +0000 Subject: [PATCH] fixed bug reported by Michael, Dietrich (mdt@emdete.de) where a large object handle was being used after the end of the transaction and thus resulting in an error. --- .../jdbc/org/postgresql/largeobject/LargeObject.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java b/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java index f5eab8310f..5910482bff 100644 --- a/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java +++ b/src/interfaces/jdbc/org/postgresql/largeobject/LargeObject.java @@ -92,7 +92,12 @@ public class LargeObject /* Release large object resources during garbage cleanup */ protected void finalize() throws SQLException { - close(); + //This code used to call close() however that was problematic + //because the scope of the fd is a transaction, thus if commit + //or rollback was called before garbage collection ran then + //the call to close would error out with an invalid large object + //handle. So this method now does nothing and lets the server + //handle cleanup when it ends the transaction. } /* -- 2.40.0