From f0c4d28020fb13fdbf7d6fccfab1b7b6a118ad0e Mon Sep 17 00:00:00 2001
From: Chris Lattner <sabre@nondot.org>
Date: Mon, 21 Feb 2011 21:50:25 +0000
Subject: [PATCH] more code restructuring, no functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126146 91177308-0d34-0410-b5e6-96231b3b80d8
---
lib/Sema/SemaStmt.cpp | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp
index 2e50cc3bbd..6801dd4c2e 100644
--- a/lib/Sema/SemaStmt.cpp
+++ b/lib/Sema/SemaStmt.cpp
@@ -1582,28 +1582,22 @@ StmtResult Sema::ActOnAsmStmt(SourceLocation AsmLoc, bool IsSimple,
continue;
// If the smaller input/output operand is not mentioned in the asm string,
- // then we can promote it to a larger input and the asm string won't notice.
- // Check this case now.
- bool InputMentioned = isOperandMentioned(i+NumOutputs, Pieces);
- bool OutputMentioned = isOperandMentioned(TiedTo, Pieces);
-
+ // then we can promote the smaller one to a larger input and the asm string
+ // won't notice.
bool SmallerValueMentioned = false;
// If this is a reference to the input and if the input was the smaller
// one, then we have to reject this asm.
- if (InputMentioned) {
+ if (isOperandMentioned(i+NumOutputs, Pieces)) {
// This is a use in the asm string of the smaller operand. Since we
// codegen this by promoting to a wider value, the asm will get printed
// "wrong".
- if (InSize < OutSize)
- SmallerValueMentioned = true;
+ SmallerValueMentioned |= InSize < OutSize;
}
-
- if (OutputMentioned) {
+ if (isOperandMentioned(TiedTo, Pieces)) {
// If this is a reference to the output, and if the output is the larger
// value, then it's ok because we'll promote the input to the larger type.
- if (OutSize < InSize)
- SmallerValueMentioned = true;
+ SmallerValueMentioned |= OutSize < InSize;
}
// If the smaller value wasn't mentioned in the asm string, and if the
@@ -1612,7 +1606,7 @@ StmtResult Sema::ActOnAsmStmt(SourceLocation AsmLoc, bool IsSimple,
if (!SmallerValueMentioned && InputDomain != AD_Other &&
OutputConstraintInfos[TiedTo].allowsRegister())
continue;
-
+
Diag(InputExpr->getLocStart(),
diag::err_asm_tying_incompatible_types)
<< InTy << OutTy << OutputExpr->getSourceRange()
--
2.40.0