From efca1a37676f4cd276d947658cf90b0fb625abfd Mon Sep 17 00:00:00 2001 From: Xin Tong Date: Tue, 3 Jan 2017 19:08:05 +0000 Subject: [PATCH] Enable disabled loopidiom test. Apparently we handle it now Summary: Enable disabled loopidiom test. Apparently we handle it now. Maybe due to improvements to AA. Reviewers: atrick, danielcdh, hfinkel Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D28171 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@290900 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Transforms/LoopIdiom/basic.ll | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/Transforms/LoopIdiom/basic.ll b/test/Transforms/LoopIdiom/basic.ll index 4d584de9c6f..270de2edf7a 100644 --- a/test/Transforms/LoopIdiom/basic.ll +++ b/test/Transforms/LoopIdiom/basic.ll @@ -97,8 +97,7 @@ for.end: ; preds = %entry ; CHECK: ret void } - -;; TODO: We should be able to promote this memset. Not yet though. +; Make sure the first store in the loop is turned into a memset. define void @test4(i8* %Base) nounwind ssp { bb.nph: ; preds = %entry %Base100 = getelementptr i8, i8* %Base, i64 1000 @@ -118,9 +117,8 @@ for.body: ; preds = %bb.nph, %for.body for.end: ; preds = %for.body, %entry ret void -; CHECK-TODO-LABEL: @test4( -; CHECK-TODO: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false) -; CHECK-TODO-NOT: store +; CHECK-LABEL: @test4( +; CHECK: call void @llvm.memset.p0i8.i64(i8* %Base, i8 0, i64 100, i32 1, i1 false) } ; This can't be promoted: the memset is a store of a loop variant value. -- 2.49.0