From efc18e41f122b6ccac507bd9ec1aa7cb8845c2db Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 13 Nov 2009 00:57:01 +0000 Subject: [PATCH] add a fixme, inheriting from PointerIntPair is gross :) git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@87048 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/AST/Redeclarable.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/clang/AST/Redeclarable.h b/include/clang/AST/Redeclarable.h index 1e6871ff3b..c04f3cd4e3 100644 --- a/include/clang/AST/Redeclarable.h +++ b/include/clang/AST/Redeclarable.h @@ -23,6 +23,8 @@ template class Redeclarable { protected: + // FIXME: PointerIntPair is a value class that should not be inherited from. + // This should change to using containment. struct DeclLink : public llvm::PointerIntPair { DeclLink(decl_type *D, bool isLatest) : llvm::PointerIntPair(D, isLatest) { } -- 2.50.1