From ef4b666e841e3917385892713612888ec6c3a056 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 1 Nov 2012 14:32:20 +0000 Subject: [PATCH] Fix an incorrect assert, the LHS can be an LValue. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167232 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/Expr.cpp | 2 +- test/SemaCXX/crashes.cpp | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp index 114aad5463..61dd8bd5a6 100644 --- a/lib/AST/Expr.cpp +++ b/lib/AST/Expr.cpp @@ -81,7 +81,7 @@ Expr::skipRValueSubobjectAdjustments( } } else if (const BinaryOperator *BO = dyn_cast(E)) { if (BO->isPtrMemOp()) { - assert(BO->getLHS()->isRValue()); + assert(BO->getRHS()->isRValue()); E = BO->getLHS(); const MemberPointerType *MPT = BO->getRHS()->getType()->getAs(); diff --git a/test/SemaCXX/crashes.cpp b/test/SemaCXX/crashes.cpp index b8b782a998..f5682bd74d 100644 --- a/test/SemaCXX/crashes.cpp +++ b/test/SemaCXX/crashes.cpp @@ -159,3 +159,15 @@ namespace test2 { } } } + +namespace test3 { + struct nsCSSRect { + }; + static int nsCSSRect::* sides; + nsCSSRect dimenX; + void ParseBoxCornerRadii(int y) { + switch (y) { + } + int& x = dimenX.*sides; + } +} -- 2.40.0