From edb87a4b2f15f66b73737c91020a6b86400b1dc8 Mon Sep 17 00:00:00 2001 From: bert hubert Date: Wed, 9 Dec 2015 19:08:37 +0100 Subject: [PATCH] Revert "toDNSString inexplicably did a toLower() on what it wrote it, potentially causing 0x20 issues. Now, I assume some code needed this. This commit will find that code." This reverts commit 6d04b73457106e0fbbce7846ea808cd4f4ab7c3b. --- pdns/dnsname.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pdns/dnsname.cc b/pdns/dnsname.cc index 3d4ab7309..cfd38efa0 100644 --- a/pdns/dnsname.cc +++ b/pdns/dnsname.cc @@ -115,7 +115,9 @@ std::string DNSName::toDNSString() const if (empty()) throw std::out_of_range("Attempt to DNSString an unset dnsname"); - return std::string(d_storage.c_str(), d_storage.length()); // this lowercased.. but why?! + string ret(d_storage.c_str(), d_storage.length()); + return toLower(ret); // toLower or not toLower, that is the question + // return ret; } /** -- 2.40.0