From edaab9b4522e9dd8e2e4552cc9e96fca20937e0c Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Fri, 25 Feb 2022 07:59:14 -0800 Subject: [PATCH] agwrite: [nfc] separate assignment from conditional MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Squashes an MSVC “warning C4706: assignment within conditional expression” warning. --- lib/cgraph/write.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/cgraph/write.c b/lib/cgraph/write.c index e0e2cdda8..d7c46f9dd 100644 --- a/lib/cgraph/write.c +++ b/lib/cgraph/write.c @@ -657,7 +657,8 @@ int agwrite(Agraph_t * g, void *ofile) char* s; int len; Level = 0; /* re-initialize tab level */ - if ((s = agget(g, "linelength")) && isdigit((int)*s)) { + s = agget(g, "linelength"); + if (s != NULL && isdigit((int)*s)) { len = (int)strtol(s, (char **)NULL, 10); if (len == 0 || len >= MIN_OUTPUTLINE) Max_outputline = len; -- 2.40.0