From ed8691b24be8673c2ab316991bfea885b1717f79 Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Sun, 23 Feb 2014 22:33:10 +0800 Subject: [PATCH] Fixed segfault in ext/standard/tests/strings/fprintf_variation_001.php --- ext/standard/formatted_print.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ext/standard/formatted_print.c b/ext/standard/formatted_print.c index cc5925bee7..d1ce7f9c2b 100644 --- a/ext/standard/formatted_print.c +++ b/ext/standard/formatted_print.c @@ -540,12 +540,13 @@ php_formatted_print(int param_count, int use_array, int format_offset TSRMLS_DC) } PRINTF_DEBUG(("sprintf: format character='%c'\n", format[inpos])); /* now we expect to find a type specifier */ - if (multiuse) { + //???? We don't hold zval** in args anymore + //if (multiuse) { ZVAL_DUP(&tmp, &args[argnum]); - } else { - SEPARATE_ZVAL(&args[argnum]); - ZVAL_COPY_VALUE(&tmp, &args[argnum]); - } + //} else { + // SEPARATE_ZVAL(&args[argnum]); + // ZVAL_COPY_VALUE(&tmp, &args[argnum]); + //} switch (format[inpos]) { case 's': { -- 2.50.1