From ec70889fd09a86cd8a2bca6f759569b13ba8eef5 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Thu, 14 Jan 2016 02:49:51 +0000 Subject: [PATCH] Driver: Remove SanitizerArgs::clear() function and SanitizerSet ctor, replace with in-class initializers. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@257739 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Basic/Sanitizers.h | 4 +--- include/clang/Driver/SanitizerArgs.h | 19 ++++++++----------- lib/Driver/SanitizerArgs.cpp | 17 ----------------- 3 files changed, 9 insertions(+), 31 deletions(-) diff --git a/include/clang/Basic/Sanitizers.h b/include/clang/Basic/Sanitizers.h index 98e70dee45..bfa8e516ed 100644 --- a/include/clang/Basic/Sanitizers.h +++ b/include/clang/Basic/Sanitizers.h @@ -46,8 +46,6 @@ enum SanitizerOrdinal : uint64_t { } struct SanitizerSet { - SanitizerSet() : Mask(0) {} - /// \brief Check if a certain (single) sanitizer is enabled. bool has(SanitizerMask K) const { assert(llvm::isPowerOf2_64(K)); @@ -70,7 +68,7 @@ struct SanitizerSet { bool empty() const { return Mask == 0; } /// \brief Bitmask of enabled sanitizers. - SanitizerMask Mask; + SanitizerMask Mask = 0; }; /// Parse a single value from a -fsanitize= or -fno-sanitize= value list. diff --git a/include/clang/Driver/SanitizerArgs.h b/include/clang/Driver/SanitizerArgs.h index c2611b5cd8..f3303fffbc 100644 --- a/include/clang/Driver/SanitizerArgs.h +++ b/include/clang/Driver/SanitizerArgs.h @@ -28,14 +28,14 @@ class SanitizerArgs { std::vector BlacklistFiles; std::vector ExtraDeps; - int CoverageFeatures; - int MsanTrackOrigins; - bool MsanUseAfterDtor; - bool CfiCrossDso; - int AsanFieldPadding; - bool AsanSharedRuntime; - bool LinkCXXRuntimes; - bool NeedPIE; + int CoverageFeatures = 0; + int MsanTrackOrigins = 0; + bool MsanUseAfterDtor = false; + bool CfiCrossDso = false; + int AsanFieldPadding = 0; + bool AsanSharedRuntime = false; + bool LinkCXXRuntimes = false; + bool NeedPIE = false; public: /// Parses the sanitizer arguments from an argument list. @@ -62,9 +62,6 @@ class SanitizerArgs { bool linkCXXRuntimes() const { return LinkCXXRuntimes; } void addArgs(const ToolChain &TC, const llvm::opt::ArgList &Args, llvm::opt::ArgStringList &CmdArgs, types::ID InputType) const; - - private: - void clear(); }; } // namespace driver diff --git a/lib/Driver/SanitizerArgs.cpp b/lib/Driver/SanitizerArgs.cpp index 2fded1c80d..7e617a43e4 100644 --- a/lib/Driver/SanitizerArgs.cpp +++ b/lib/Driver/SanitizerArgs.cpp @@ -180,25 +180,8 @@ bool SanitizerArgs::needsUnwindTables() const { return Sanitizers.Mask & NeedsUnwindTables; } -void SanitizerArgs::clear() { - Sanitizers.clear(); - RecoverableSanitizers.clear(); - TrapSanitizers.clear(); - BlacklistFiles.clear(); - ExtraDeps.clear(); - CoverageFeatures = 0; - MsanTrackOrigins = 0; - MsanUseAfterDtor = false; - NeedPIE = false; - AsanFieldPadding = 0; - AsanSharedRuntime = false; - LinkCXXRuntimes = false; - CfiCrossDso = false; -} - SanitizerArgs::SanitizerArgs(const ToolChain &TC, const llvm::opt::ArgList &Args) { - clear(); SanitizerMask AllRemove = 0; // During the loop below, the accumulated set of // sanitizers disabled by the current sanitizer // argument or any argument after it. -- 2.40.0