From eba6789e6c04a6a364a5396e1a0c1d041f9504cc Mon Sep 17 00:00:00 2001 From: alarruskain Date: Mon, 13 Mar 2017 13:31:01 +0100 Subject: [PATCH] Fix late argument verification in emac-main Prevent crash when emac_phy_power_enable is not set. Merges #426 https://github.com/espressif/esp-idf/pull/426 --- components/ethernet/emac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/ethernet/emac_main.c b/components/ethernet/emac_main.c index 8c93a1830e..672ab75dfc 100644 --- a/components/ethernet/emac_main.c +++ b/components/ethernet/emac_main.c @@ -948,14 +948,14 @@ esp_err_t esp_eth_init(eth_config_t *config) emac_set_user_config_data(config); } - emac_config.emac_phy_power_enable(true); - ret = emac_verify_args(); if (ret != ESP_OK) { goto _exit; } + emac_config.emac_phy_power_enable(true); + //before set emac reg must enable clk emac_enable_clk(true); REG_SET_FIELD(EMAC_EX_PHYINF_CONF_REG, EMAC_EX_PHY_INTF_SEL, EMAC_EX_PHY_INTF_RMII); -- 2.40.0