From eb94ee7f0f38cd24270bfb2f655cdec214a4d6e0 Mon Sep 17 00:00:00 2001 From: Kazuki Yamaguchi Date: Fri, 8 Apr 2016 23:02:30 +0900 Subject: [PATCH] imap-send: fix CRAM-MD5 response calculation Remove extra + 1 from resp_len, the length of the byte sequence to be Base64 encoded and passed to the server as the response. Or the response incorrectly contains an extra \0. Signed-off-by: Kazuki Yamaguchi Signed-off-by: Junio C Hamano --- imap-send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/imap-send.c b/imap-send.c index 30979f0c63..407e46bc8c 100644 --- a/imap-send.c +++ b/imap-send.c @@ -890,7 +890,7 @@ static char *cram(const char *challenge_64, const char *user, const char *pass) /* response: " " */ response = xstrfmt("%s %s", user, hex); - resp_len = strlen(response) + 1; + resp_len = strlen(response); response_64 = xmallocz(ENCODED_SIZE(resp_len)); encoded_len = EVP_EncodeBlock((unsigned char *)response_64, -- 2.40.0