From e99e3c26c855bd47d82a9b72f901e7d789453eeb Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Sat, 7 May 2016 05:10:11 -0600 Subject: [PATCH] In sudo_edit_create_tfiles(), fix fd leak if sudo_edit_mktemp() fails. Coverity CID 104114. --- src/sudo_edit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sudo_edit.c b/src/sudo_edit.c index 8679f7e2e..1661899e4 100644 --- a/src/sudo_edit.c +++ b/src/sudo_edit.c @@ -558,6 +558,8 @@ sudo_edit_create_tfiles(struct command_details *command_details, sudo_fatal("seteuid(ROOT_UID)"); if (tfd == -1) { sudo_warn("mkstemps"); + if (ofd != -1) + close(ofd); debug_return_int(-1); } if (ofd != -1) { -- 2.40.0