From e78fad81ecb318619aabe6639e4ab54d11c1fc9e Mon Sep 17 00:00:00 2001 From: Max Kazantsev Date: Mon, 30 Oct 2017 04:48:34 +0000 Subject: [PATCH] [GVN][NFC] Mark instruction for deletion instead of immediate erasing in LoadPRE It is done to uniformly handle instructions removal. Differential Revision: https://reviews.llvm.org/D39369 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@316884 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/GVN.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/Transforms/Scalar/GVN.cpp b/lib/Transforms/Scalar/GVN.cpp index d7dcfd2eb16..7e416368468 100644 --- a/lib/Transforms/Scalar/GVN.cpp +++ b/lib/Transforms/Scalar/GVN.cpp @@ -1167,8 +1167,7 @@ bool GVN::PerformLoadPRE(LoadInst *LI, AvailValInBlkVect &ValuesPerBlock, if (!CanDoPRE) { while (!NewInsts.empty()) { Instruction *I = NewInsts.pop_back_val(); - if (MD) MD->removeInstruction(I); - I->eraseFromParent(); + markInstructionForDeletion(I); } // HINT: Don't revert the edge-splitting as following transformation may // also need to split these critical edges. -- 2.50.1