From e6b3cbefe6124767dcd2aa8d9fe399ccebb3a95f Mon Sep 17 00:00:00 2001 From: Kristof Umann Date: Thu, 27 Sep 2018 12:46:37 +0000 Subject: [PATCH] Revert untintentionally commited changes git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@343205 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../Checkers/UninitializedObject/UninitializedObject.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h b/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h index 828955dc10..d10b862ea0 100644 --- a/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h +++ b/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h @@ -79,9 +79,9 @@ class FieldNode { protected: const FieldRegion *FR; - // TODO: This destructor shouldn't be virtual, but breaks buildbots with - // -Werror -Wnon-virtual-dtor. - virtual ~FieldNode() = default; + /// FieldNodes are never meant to be created on the heap, see + /// FindUninitializedFields::addFieldToUninits(). + /* non-virtual */ ~FieldNode() = default; public: FieldNode(const FieldRegion *FR) : FR(FR) {} -- 2.50.1