From e6721c6e1617a0fc8b4bce8eacba8b5a381f1f21 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 27 Oct 2010 15:26:24 -0400 Subject: [PATCH] Previous patch had no detectable virtue other than being a one-liner. Try to make the code look self-consistent again, so it doesn't confuse future developers. --- src/backend/postmaster/postmaster.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index f24a091ef8..0fb11833fa 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -1956,6 +1956,8 @@ canAcceptConnections(void) /* * ConnCreate -- create a local connection data structure + * + * Returns NULL on failure, other than out-of-memory which is fatal. */ static Port * ConnCreate(int serverFd) @@ -1977,17 +1979,15 @@ ConnCreate(int serverFd) ConnFree(port); return NULL; } - else - { - /* - * Precompute password salt values to use for this connection. It's - * slightly annoying to do this long in advance of knowing whether - * we'll need 'em or not, but we must do the random() calls before we - * fork, not after. Else the postmaster's random sequence won't get - * advanced, and all backends would end up using the same salt... - */ - RandomSalt(port->md5Salt); - } + + /* + * Precompute password salt values to use for this connection. It's + * slightly annoying to do this long in advance of knowing whether + * we'll need 'em or not, but we must do the random() calls before we + * fork, not after. Else the postmaster's random sequence won't get + * advanced, and all backends would end up using the same salt... + */ + RandomSalt(port->md5Salt); /* * Allocate GSSAPI specific state struct -- 2.40.0