From e57f1b192a86b9e2cd3892d28acfeaa53298bf21 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Sun, 24 Nov 2013 23:40:06 +0000 Subject: [PATCH] remove gcc::Precompile Clang still has support for running gcc for performing various stages of a build. Right now it looks like this is used for * Supporting Fortran in the clang driver * Running an assembler or linker in systems we don't yet know how to run them directly. It looks like the gcc::Precompile is a vestige from the days when we supported using clang for C and running gcc for c++. This patch removes it (yes, we have no tests for it). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@195586 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/ToolChains.cpp | 4 ---- lib/Driver/ToolChains.h | 1 - lib/Driver/Tools.cpp | 5 ----- lib/Driver/Tools.h | 12 ------------ 4 files changed, 22 deletions(-) diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp index 5f0b167f29..d9ad587a0f 100644 --- a/lib/Driver/ToolChains.cpp +++ b/lib/Driver/ToolChains.cpp @@ -1574,10 +1574,6 @@ Tool *Generic_GCC::getTool(Action::ActionClass AC) const { if (!Preprocess) Preprocess.reset(new tools::gcc::Preprocess(*this)); return Preprocess.get(); - case Action::PrecompileJobClass: - if (!Precompile) - Precompile.reset(new tools::gcc::Precompile(*this)); - return Precompile.get(); case Action::CompileJobClass: if (!Compile) Compile.reset(new tools::gcc::Compile(*this)); diff --git a/lib/Driver/ToolChains.h b/lib/Driver/ToolChains.h index 60fb75d9a8..ed5c1ac202 100644 --- a/lib/Driver/ToolChains.h +++ b/lib/Driver/ToolChains.h @@ -183,7 +183,6 @@ protected: private: mutable OwningPtr Preprocess; - mutable OwningPtr Precompile; mutable OwningPtr Compile; }; diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 2742332d66..d3314eb180 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -4263,11 +4263,6 @@ void gcc::Preprocess::RenderExtraToolArgs(const JobAction &JA, CmdArgs.push_back("-E"); } -void gcc::Precompile::RenderExtraToolArgs(const JobAction &JA, - ArgStringList &CmdArgs) const { - // The type is good enough. -} - void gcc::Compile::RenderExtraToolArgs(const JobAction &JA, ArgStringList &CmdArgs) const { const Driver &D = getToolChain().getDriver(); diff --git a/lib/Driver/Tools.h b/lib/Driver/Tools.h index 260b8c7ccc..e4b1fdfad8 100644 --- a/lib/Driver/Tools.h +++ b/lib/Driver/Tools.h @@ -139,18 +139,6 @@ namespace gcc { llvm::opt::ArgStringList &CmdArgs) const; }; - class LLVM_LIBRARY_VISIBILITY Precompile : public Common { - public: - Precompile(const ToolChain &TC) : Common("gcc::Precompile", - "gcc precompile", TC) {} - - virtual bool hasGoodDiagnostics() const { return true; } - virtual bool hasIntegratedCPP() const { return true; } - - virtual void RenderExtraToolArgs(const JobAction &JA, - llvm::opt::ArgStringList &CmdArgs) const; - }; - class LLVM_LIBRARY_VISIBILITY Compile : public Common { public: Compile(const ToolChain &TC) : Common("gcc::Compile", -- 2.40.0