From e536ca663f9d3d9c9fc413f2f48e1801902c44ac Mon Sep 17 00:00:00 2001
From: Alina Sbirlea <asbirlea@google.com>
Date: Tue, 1 Oct 2019 19:09:50 +0000
Subject: [PATCH] [MemorySSA] Check for unreachable blocks when getting last
 definition.

If a single predecessor is found, still check if the block is
unreachable. The test that found this had a self loop unreachable block.
Resolves PR43493.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@373383 91177308-0d34-0410-b5e6-96231b3b80d8
---
 lib/Analysis/MemorySSAUpdater.cpp  |  3 +++
 test/Analysis/MemorySSA/pr43493.ll | 27 +++++++++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 test/Analysis/MemorySSA/pr43493.ll

diff --git a/lib/Analysis/MemorySSAUpdater.cpp b/lib/Analysis/MemorySSAUpdater.cpp
index 315037bcc04..e0b27f1d501 100644
--- a/lib/Analysis/MemorySSAUpdater.cpp
+++ b/lib/Analysis/MemorySSAUpdater.cpp
@@ -839,6 +839,9 @@ void MemorySSAUpdater::applyInsertUpdates(ArrayRef<CFGUpdate> Updates,
       } else {
         // Single predecessor, BB cannot be dead. GetLastDef of Pred.
         assert(Count == 1 && Pred && "Single predecessor expected.");
+        // BB can be unreachable though, return LoE if that is the case.
+        if (!DT.getNode(BB))
+          return MSSA->getLiveOnEntryDef();
         BB = Pred;
       }
     };
diff --git a/test/Analysis/MemorySSA/pr43493.ll b/test/Analysis/MemorySSA/pr43493.ll
new file mode 100644
index 00000000000..69506e8c043
--- /dev/null
+++ b/test/Analysis/MemorySSA/pr43493.ll
@@ -0,0 +1,27 @@
+; RUN: opt -enable-mssa-loop-dependency=true -loop-rotate -verify-memoryssa -S %s | FileCheck %s
+; REQUIRES: asserts
+
+; CHECK-LABEL: @func_35()
+define void @func_35() {
+entry:
+  br i1 undef, label %for.cond1704.preheader, label %return
+
+for.cond1704.preheader:                           ; preds = %entry
+  br label %for.cond1704
+
+for.cond1704:                                     ; preds = %for.cond1704.preheader, %for.body1707
+  br i1 false, label %for.body1707, label %return.loopexit
+
+for.body1707:                                     ; preds = %for.cond1704
+  store i32 1712, i32* undef, align 1
+  br label %for.cond1704
+
+for.body1102:                                     ; preds = %for.body1102
+  br i1 undef, label %for.body1102, label %return
+
+return.loopexit:                                  ; preds = %for.cond1704
+  br label %return
+
+return:                                           ; preds = %return.loopexit, %for.body1102, %entry
+  ret void
+}
-- 
2.40.0