From e4e1746b3f9b97b5bb655f64a3e0e50a8e4425b6 Mon Sep 17 00:00:00 2001 From: George Peter Banyard Date: Wed, 5 Feb 2020 17:44:20 +0100 Subject: [PATCH] Remove unnecessary condition as always true. ZSTR_LEN(str) is an unsigned integer therefor it is always greater or equal than 0. Detected by -Wtype-limits compiler warning. --- ext/iconv/iconv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/iconv/iconv.c b/ext/iconv/iconv.c index 7267632dd4..36fdcf6198 100644 --- a/ext/iconv/iconv.c +++ b/ext/iconv/iconv.c @@ -2052,7 +2052,7 @@ PHP_FUNCTION(iconv_substr) err = _php_iconv_substr(&retval, ZSTR_VAL(str), ZSTR_LEN(str), offset, length, charset); _php_iconv_show_error(err, GENERIC_SUPERSET_NAME, charset); - if (err == PHP_ICONV_ERR_SUCCESS && ZSTR_LEN(str) >= 0 && retval.s != NULL) { + if (err == PHP_ICONV_ERR_SUCCESS && retval.s != NULL) { RETURN_NEW_STR(retval.s); } smart_str_free(&retval); -- 2.40.0