From e3b576dd4d3b12a063e45737224687cd78e0d98c Mon Sep 17 00:00:00 2001 From: George Karpenkov Date: Thu, 25 Oct 2018 23:38:24 +0000 Subject: [PATCH] [analyzer] Remove custom rule for OSIterator in RetainCountChecker Differential Revision: https://reviews.llvm.org/D53628 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@345339 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp b/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp index e9333266ce..1a2dc28a57 100644 --- a/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp +++ b/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp @@ -69,10 +69,6 @@ static bool isOSObjectDynamicCast(StringRef S) { return S == "safeMetaCast"; } -static bool isOSIteratorSubclass(const Decl *D) { - return isSubclass(D, "OSIterator"); -} - static bool hasRCAnnotation(const Decl *D, StringRef rcAnnotation) { for (const auto *Ann : D->specific_attrs()) { if (Ann->getAnnotation() == rcAnnotation) @@ -240,10 +236,6 @@ RetainSummaryManager::generateSummary(const FunctionDecl *FD, // All objects returned with functions starting with "get" are getters. if (II->getName().startswith("get")) { - - // ...except for iterators. - if (isOSIteratorSubclass(PD)) - return getOSSummaryCreateRule(FD); return getOSSummaryGetRule(FD); } else { return getOSSummaryCreateRule(FD); -- 2.50.1