From e35b657efd1b2eae89497233f6494f8323d5ad1e Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Tue, 19 Jul 2005 22:20:20 +0000 Subject: [PATCH] Fix cleanup DECREF logic in builtin_filter function. --- Python/bltinmodule.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c index 145e9460f1..f63e27adc6 100644 --- a/Python/bltinmodule.c +++ b/Python/bltinmodule.c @@ -210,10 +210,15 @@ builtin_filter(PyObject *self, PyObject *args) if (PyTuple_Check(seq)) return filtertuple(func, seq); + /* Pre-allocate argument list tuple. */ + arg = PyTuple_New(1); + if (arg == NULL) + return NULL; + /* Get iterator. */ it = PyObject_GetIter(seq); if (it == NULL) - return NULL; + goto Fail_arg; /* Guess a result list size. */ len = PyObject_Size(seq); @@ -222,11 +227,6 @@ builtin_filter(PyObject *self, PyObject *args) len = 8; /* arbitrary */ } - /* Pre-allocate argument list tuple. */ - arg = PyTuple_New(1); - if (arg == NULL) - goto Fail_arg; - /* Get a result list. */ if (PyList_Check(seq) && seq->ob_refcnt == 1) { /* Eww - can modify the list in-place. */ -- 2.49.0