From e24f706682d23697bc7d7d31a2041504dc4b478d Mon Sep 17 00:00:00 2001 From: Michael Kuperstein Date: Sat, 21 Jan 2017 02:03:03 +0000 Subject: [PATCH] [SLP] Make ReductionOpcode have the right (enum) type. NFC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@292703 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Vectorize/SLPVectorizer.cpp | 23 ++++++++++------------ 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/lib/Transforms/Vectorize/SLPVectorizer.cpp b/lib/Transforms/Vectorize/SLPVectorizer.cpp index 717790be13c..932c8413dc9 100644 --- a/lib/Transforms/Vectorize/SLPVectorizer.cpp +++ b/lib/Transforms/Vectorize/SLPVectorizer.cpp @@ -4135,7 +4135,7 @@ class HorizontalReduction { WeakVH ReductionPHI; /// The opcode of the reduction. - unsigned ReductionOpcode; + Instruction::BinaryOps ReductionOpcode; /// The opcode of the values we perform a reduction on. unsigned ReducedValueOpcode; /// Should we model this reduction as a pairwise reduction tree or a tree that @@ -4151,8 +4151,8 @@ public: unsigned MinVecRegSize; HorizontalReduction(unsigned MinVecRegSize) - : ReductionRoot(nullptr), ReductionOpcode(0), ReducedValueOpcode(0), - IsPairwiseReduction(false), ReduxWidth(0), + : ReductionRoot(nullptr), ReductionOpcode(Instruction::BinaryOpsEnd), + ReducedValueOpcode(0), IsPairwiseReduction(false), ReduxWidth(0), MinVecRegSize(MinVecRegSize) {} /// \brief Try to find a reduction tree. @@ -4302,9 +4302,8 @@ public: Value *ReducedSubTree = emitReduction(VectorizedRoot, Builder); if (VectorizedTree) { Builder.SetCurrentDebugLocation(Loc); - VectorizedTree = - Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode, - VectorizedTree, ReducedSubTree, "bin.rdx"); + VectorizedTree = Builder.CreateBinOp(ReductionOpcode, VectorizedTree, + ReducedSubTree, "bin.rdx"); } else VectorizedTree = ReducedSubTree; } @@ -4314,9 +4313,8 @@ public: for (; i < NumReducedVals; ++i) { Builder.SetCurrentDebugLocation( cast(ReducedVals[i])->getDebugLoc()); - VectorizedTree = - Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode, - VectorizedTree, ReducedVals[i]); + VectorizedTree = Builder.CreateBinOp(ReductionOpcode, VectorizedTree, + ReducedVals[i]); } // Update users. if (ReductionPHI && !isa(ReductionPHI)) { @@ -4377,15 +4375,14 @@ private: Value *RightShuf = Builder.CreateShuffleVector( TmpVec, UndefValue::get(TmpVec->getType()), (RightMask), "rdx.shuf.r"); - TmpVec = Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode, - LeftShuf, RightShuf, "bin.rdx"); + TmpVec = Builder.CreateBinOp(ReductionOpcode, LeftShuf, RightShuf, + "bin.rdx"); } else { Value *UpperHalf = createRdxShuffleMask(ReduxWidth, i, false, false, Builder); Value *Shuf = Builder.CreateShuffleVector( TmpVec, UndefValue::get(TmpVec->getType()), UpperHalf, "rdx.shuf"); - TmpVec = Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode, - TmpVec, Shuf, "bin.rdx"); + TmpVec = Builder.CreateBinOp(ReductionOpcode, TmpVec, Shuf, "bin.rdx"); } } -- 2.50.1