From e24ca7ffc83065e579bae531f1027aec7ebbfd8a Mon Sep 17 00:00:00 2001 From: Jim Jagielski Date: Sun, 7 Jul 2013 14:14:12 +0000 Subject: [PATCH] comment and vote git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1500439 13f79535-47bb-0310-9956-ffa450edef68 --- STATUS | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/STATUS b/STATUS index 5efb020e5c..c317e7feb9 100644 --- a/STATUS +++ b/STATUS @@ -124,15 +124,23 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/viewvc?view=revision&revision=1482859 http://svn.apache.org/viewvc?view=revision&revision=1483190 http://svn.apache.org/viewvc?view=revision&revision=1484343 + http://svn.apache.org/viewvc?view=revision&revision=1500437 2.4.x patch: trunk works, modulo CHANGES +1: jim, minfrin sf says: - - ap_proxy_sync_balancer() seems to use conf->pool in several - places, but only one place is protected by conf->mutex. - I don't think this is correct. - Also, I can't find any place where conf->mutex is initialized. - - ap_proxy_initialize_worker() is called from proxy_handler() with - conf->pool. I guess this should also be mutex protected? + - ap_proxy_sync_balancer() seems to use conf->pool in several + places, but only one place is protected by conf->mutex. + I don't think this is correct. + Also, I can't find any place where conf->mutex is initialized. + jj says: + - conf->pool is used in 2 places, both are now protected + sf says: + - ap_proxy_initialize_worker() is called from proxy_handler() with + conf->pool. I guess this should also be mutex protected? + jj says: + - it is: ap_proxy_initialize_worker() uses the mutex internally. + (line ~1735) + * mod_proxy_http: Make the proxy-interim-response environment variable effective by formally overriding origin server behaviour. @@ -153,6 +161,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/r1498880 2.4.x patch: http://people.apache.org/~sf/open_htaccess_hook.patch +1: sf, jorton, + -0.5: jj: I would prefer if this sat in trunk for a few months first + to receive more testing. * mod_proxy: Connection header clearing issues trunk patch: https://svn.apache.org/viewvc?view=revision&revision=1481891 -- 2.40.0