From e13a4238e5ea960093b29f74dd7367d3970324ee Mon Sep 17 00:00:00 2001 From: Arnaud Le Blanc Date: Tue, 11 Nov 2008 01:55:51 +0000 Subject: [PATCH] MFH: Fixed stream_get_contents() when using $maxlength and socket is not closed. indeyets@php.net on #46049. --- .../tests/streams/stream_get_contents_002.phpt | 18 ++++++++++++++++++ main/streams/streams.c | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 ext/standard/tests/streams/stream_get_contents_002.phpt diff --git a/ext/standard/tests/streams/stream_get_contents_002.phpt b/ext/standard/tests/streams/stream_get_contents_002.phpt new file mode 100644 index 0000000000..66ff3fb189 --- /dev/null +++ b/ext/standard/tests/streams/stream_get_contents_002.phpt @@ -0,0 +1,18 @@ +--TEST-- +stream_get_contents() - Testing on socket with $maxlength +--SKIPIF-- + +--FILE-- + +--EXPECT-- +string(3) "foo" diff --git a/main/streams/streams.c b/main/streams/streams.c index 530a8d8e14..a2c956c3af 100755 --- a/main/streams/streams.c +++ b/main/streams/streams.c @@ -1243,7 +1243,7 @@ PHPAPI size_t _php_stream_copy_to_mem(php_stream *src, char **buf, size_t maxlen if (maxlen > 0) { ptr = *buf = pemalloc_rel_orig(maxlen + 1, persistent); - while ((len < maxlen) & !php_stream_eof(src)) { + while ((len < maxlen) && !php_stream_eof(src)) { ret = php_stream_read(src, ptr, maxlen - len); len += ret; ptr += ret; -- 2.50.1