From e132db7a57a6afc53cceec15f19541ec29d8233a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gustavo=20Andr=C3=A9=20dos=20Santos=20Lopes?= Date: Sat, 17 Mar 2012 19:37:30 +0000 Subject: [PATCH] - Fixed bug #61371 (resource leak). This bug had two parts, a long standing leak already fixed in trunk/5.3 and now merged onto 5.4 and a leak introduced in fixing bug #61115. This better fix for #61115 fixes the leak (the inhibition for deleting the context was too broad) and so prevents segfaults in new circumstances (where the inhibition was not broad enough). --- ext/standard/tests/streams/bug61115-1.phpt | 11 ++++++ ext/standard/tests/streams/bug61115-2.phpt | 10 ++++++ ext/standard/tests/streams/bug61371.phpt | 40 ++++++++++++++++++++++ main/streams/streams.c | 2 +- 4 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 ext/standard/tests/streams/bug61115-1.phpt create mode 100644 ext/standard/tests/streams/bug61115-2.phpt create mode 100644 ext/standard/tests/streams/bug61371.phpt diff --git a/ext/standard/tests/streams/bug61115-1.phpt b/ext/standard/tests/streams/bug61115-1.phpt new file mode 100644 index 0000000000..43c54b4974 --- /dev/null +++ b/ext/standard/tests/streams/bug61115-1.phpt @@ -0,0 +1,11 @@ +--TEST-- +Bug #61115: Stream related segfault on fatal error in php_stream_context_del_link - variation 1 +--FILE-- + +--EXPECTF-- +Fatal error: Allowed memory size of %d bytes exhausted at %s:%d (tried to allocate %d bytes) in %s on line %d diff --git a/ext/standard/tests/streams/bug61115-2.phpt b/ext/standard/tests/streams/bug61115-2.phpt new file mode 100644 index 0000000000..260b8369df --- /dev/null +++ b/ext/standard/tests/streams/bug61115-2.phpt @@ -0,0 +1,10 @@ +--TEST-- +Bug #61115: Stream related segfault on fatal error in php_stream_context_del_link - variation 2 +--FILE-- + +==DONE== +--EXPECT-- +==DONE== diff --git a/ext/standard/tests/streams/bug61371.phpt b/ext/standard/tests/streams/bug61371.phpt new file mode 100644 index 0000000000..7fbfa56ba2 --- /dev/null +++ b/ext/standard/tests/streams/bug61371.phpt @@ -0,0 +1,40 @@ +--TEST-- +Bug #61371: stream_context_create() causes memory leaks on use streams_socket_create +--FILE-- + +--EXPECTF-- +memory: %dkb +bool(true) +memory: %dkb +bool(true) +memory: %dkb +memory: %dkb +bool(true) +memory: %dkb +bool(true) +memory: %dkb diff --git a/main/streams/streams.c b/main/streams/streams.c index 3da13e5069..b623ffb201 100755 --- a/main/streams/streams.c +++ b/main/streams/streams.c @@ -390,7 +390,7 @@ PHPAPI int _php_stream_free(php_stream *stream, int close_options TSRMLS_DC) /* /* on an resource list destruction, the context, another resource, may have * already been freed (if it was created after the stream resource), so * don't reference it */ - if (!(close_options & PHP_STREAM_FREE_RSRC_DTOR)) { + if (EG(active)) { context = stream->context; } -- 2.40.0