From e0d9879b7a0840e5e34278adb83651836533b17b Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Mon, 5 Jan 2015 21:44:15 +0000 Subject: [PATCH] Use the integrated assembler by default on 32-bit PowerPC and SPARC git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@225212 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/ToolChains.cpp | 3 +++ lib/Driver/ToolChains.h | 27 --------------------------- test/Driver/freebsd.c | 4 ++-- test/Driver/unknown-gcc-arch.c | 4 ++-- 4 files changed, 7 insertions(+), 31 deletions(-) diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp index 99f4c9dfea..4d97ab3bf4 100644 --- a/lib/Driver/ToolChains.cpp +++ b/lib/Driver/ToolChains.cpp @@ -2067,8 +2067,11 @@ bool Generic_GCC::IsIntegratedAssemblerDefault() const { getTriple().getArch() == llvm::Triple::armeb || getTriple().getArch() == llvm::Triple::thumb || getTriple().getArch() == llvm::Triple::thumbeb || + getTriple().getArch() == llvm::Triple::ppc || getTriple().getArch() == llvm::Triple::ppc64 || getTriple().getArch() == llvm::Triple::ppc64le || + getTriple().getArch() == llvm::Triple::sparc || + getTriple().getArch() == llvm::Triple::sparcv9 || getTriple().getArch() == llvm::Triple::systemz; } diff --git a/lib/Driver/ToolChains.h b/lib/Driver/ToolChains.h index 876bb01f33..c9658c43a8 100644 --- a/lib/Driver/ToolChains.h +++ b/lib/Driver/ToolChains.h @@ -534,17 +534,6 @@ public: return 2; } - virtual bool IsIntegratedAssemblerDefault() const override { - switch (getTriple().getArch()) { - case llvm::Triple::ppc: - case llvm::Triple::sparc: - case llvm::Triple::sparcv9: - return true; - default: - return Generic_ELF::IsIntegratedAssemblerDefault(); - } - } - protected: Tool *buildAssembler() const override; Tool *buildLinker() const override; @@ -586,14 +575,6 @@ public: void AddClangCXXStdlibIncludeArgs(const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const override; - bool IsIntegratedAssemblerDefault() const override { - switch (getTriple().getArch()) { - case llvm::Triple::ppc: - return true; - default: - return Generic_ELF::IsIntegratedAssemblerDefault(); - } - } bool UseSjLjExceptions() const override; bool isPIEDefault() const override; @@ -618,14 +599,6 @@ public: bool IsUnwindTablesDefault() const override { return true; } - bool IsIntegratedAssemblerDefault() const override { - switch (getTriple().getArch()) { - case llvm::Triple::ppc: - return true; - default: - return Generic_ELF::IsIntegratedAssemblerDefault(); - } - } protected: Tool *buildAssembler() const override; diff --git a/test/Driver/freebsd.c b/test/Driver/freebsd.c index 0c04fd2309..a7448c11bf 100644 --- a/test/Driver/freebsd.c +++ b/test/Driver/freebsd.c @@ -128,11 +128,11 @@ // RUN: | FileCheck --check-prefix=CHECK-LTO %s // CHECK-LTO: ld{{.*}}" "-plugin{{.*}}LLVMgold.so -// RUN: %clang -target sparc-unknown-freebsd8 %s -### -fpic 2>&1 \ +// RUN: %clang -target sparc-unknown-freebsd8 %s -### -fpic -no-integrated-as 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-SPARC-PIE %s // CHECK-SPARC-PIE: as{{.*}}" "-KPIC -// RUN: %clang -mcpu=ultrasparc -target sparc64-unknown-freebsd8 %s -### 2>&1 \ +// RUN: %clang -mcpu=ultrasparc -target sparc64-unknown-freebsd8 %s -### -no-integrated-as 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-SPARC-CPU %s // CHECK-SPARC-CPU: cc1{{.*}}" "-target-cpu" "ultrasparc" // CHECK-SPARC-CPU: as{{.*}}" "-Av9a diff --git a/test/Driver/unknown-gcc-arch.c b/test/Driver/unknown-gcc-arch.c index 9e687b76a4..2aba50d532 100644 --- a/test/Driver/unknown-gcc-arch.c +++ b/test/Driver/unknown-gcc-arch.c @@ -24,11 +24,11 @@ // RUN: %clang -target powerpc64-unknown-unknown -c -x assembler %s -### -m32 \ -// RUN: 2>&1 | FileCheck -check-prefix=PPC64-M32 %s +// RUN: -no-integrated-as 2>&1 | FileCheck -check-prefix=PPC64-M32 %s // PPC64-M32: {{.*as.*-a32}} // RUN: %clang -target powerpc-unknown-unknown -c -x assembler %s -### 2>&1 \ -// RUN: | FileCheck -check-prefix=PPC %s +// RUN: -no-integrated-as | FileCheck -check-prefix=PPC %s // PPC: {{.*as.*-a32}} // RUN: %clang -target sparc64-unknown-unknown -no-integrated-as -c -x assembler %s -### -m32 2>&1 \ -- 2.40.0