From df43fcf4575cf77d85f4c4dcc096661905a6eb33 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 22 Jan 2016 20:04:35 -0300 Subject: [PATCH] pg_dump: Fix quoting of domain constraint names The original code was adding double quotes to an already-quoted identifier, leading to nonsensical results. Remove the quoting call. I introduced the broken code in 7eca575d1c of 9.5 era, so backpatch to 9.5. Report and patch by Elvis Pranskevichus Reviewed by Michael Paquier --- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 9c6f88540e..de1ece17c0 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -9611,7 +9611,7 @@ dumpDomain(Archive *fout, TypeInfo *tyinfo) appendPQExpBuffer(labelq, "CONSTRAINT %s ", fmtId(domcheck->dobj.name)); appendPQExpBuffer(labelq, "ON DOMAIN %s", - fmtId(qtypname)); + qtypname); dumpComment(fout, labelq->data, tyinfo->dobj.namespace->dobj.name, tyinfo->rolname, -- 2.40.0