From debfc866d2971c69d4f47662fb4bb70feb0c0007 Mon Sep 17 00:00:00 2001 From: Remi Collet Date: Mon, 7 Sep 2015 13:52:28 +0200 Subject: [PATCH] Fix build php_zip.c:1647:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses] php_zip.c:1648:3: error: format not a string literal and no format arguments [-Werror=format-security] --- ext/zip/php_zip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c index 0355db48e5..c203148334 100644 --- a/ext/zip/php_zip.c +++ b/ext/zip/php_zip.c @@ -1626,8 +1626,8 @@ static ZIPARCHIVE_METHOD(close) ze_obj = (ze_zip_object*) zend_object_store_get_object(this TSRMLS_CC); - if (err = zip_close(intern)) { - php_error_docref(NULL TSRMLS_CC, E_WARNING, zip_strerror(intern)); + if ((err = zip_close(intern))) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s", zip_strerror(intern)); zip_discard(intern); } -- 2.49.0