From ddcb8c134b84bb9802732c0d13970f643c7ee91d Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Wed, 10 Sep 2014 18:23:34 +0000 Subject: [PATCH] Objective-C arc. Fixes a crash when issuing diagnostic for passing parameter to an audited CF API. rdar://18222007 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@217530 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExpr.cpp | 2 +- test/SemaObjC/objc-cf-audited-warning.m | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 test/SemaObjC/objc-cf-audited-warning.m diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index c23bbf0b12..57c4f33ca0 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -10994,7 +10994,7 @@ bool Sema::DiagnoseAssignmentResult(AssignConvertType ConvTy, PartialDiagnostic FDiag = PDiag(DiagKind); if (Action == AA_Passing_CFAudited) - FDiag << FirstType << SecondType << SrcExpr->getSourceRange(); + FDiag << FirstType << SecondType << AA_Passing << SrcExpr->getSourceRange(); else FDiag << FirstType << SecondType << Action << SrcExpr->getSourceRange(); diff --git a/test/SemaObjC/objc-cf-audited-warning.m b/test/SemaObjC/objc-cf-audited-warning.m new file mode 100644 index 0000000000..db782299b8 --- /dev/null +++ b/test/SemaObjC/objc-cf-audited-warning.m @@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -fobjc-arc -verify %s +// rdar://18222007 + +#if __has_feature(arc_cf_code_audited) +#define CF_IMPLICIT_BRIDGING_ENABLED _Pragma("clang arc_cf_code_audited begin") +#define CF_IMPLICIT_BRIDGING_DISABLED _Pragma("clang arc_cf_code_audited end") +#endif +#define CF_BRIDGED_TYPE(T) __attribute__((objc_bridge(T))) + +typedef const struct CF_BRIDGED_TYPE(NSURL) __CFURL * CFURLRef; +typedef signed long long CFIndex; +typedef unsigned char Boolean; +typedef unsigned char UInt8; +typedef const struct __CFAllocator * CFAllocatorRef; +const CFAllocatorRef kCFAllocatorDefault; + +CF_IMPLICIT_BRIDGING_ENABLED +CFURLRef CFURLCreateFromFileSystemRepresentation(CFAllocatorRef allocator, const UInt8 *buffer, CFIndex bufLen, Boolean isDirectory); // expected-note {{passing argument to parameter 'buffer' here}} +CF_IMPLICIT_BRIDGING_DISABLED + +void saveImageToJPG(const char *filename) +{ + CFURLRef url = CFURLCreateFromFileSystemRepresentation(kCFAllocatorDefault, filename, 10, 0); // expected-warning {{passing 'const char *' to parameter of type 'const UInt8 *' (aka 'const unsigned char *') converts between pointers to integer types with different sign}} +} -- 2.40.0