From ddb356daba7cdb4b0bc385c9371ea20e38d46bab Mon Sep 17 00:00:00 2001 From: Richard Russon Date: Thu, 13 Apr 2017 12:24:05 +0100 Subject: [PATCH] revert broken fix This IS the site of a possible bug, but this isn't the way to fix it. Some paths through parse_set() will lead to (idx == -1) which will cause a buffer underrun when used as an index to MuttVars. closes #520 --- init.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/init.c b/init.c index 316d7648a..a4f573bb6 100644 --- a/init.c +++ b/init.c @@ -2336,10 +2336,6 @@ static int parse_set (BUFFER *tmp, BUFFER *s, unsigned long data, BUFFER *err) restore_default (&MuttVars[idx]); } } - else if (idx < 0) - { - return -1; - } else if (!myvar && DTYPE (MuttVars[idx].type) == DT_BOOL) { if (*s->dptr == '=') -- 2.49.0