From dda82a2eabefcf3e044c5d3bbe78954dfc0e4248 Mon Sep 17 00:00:00 2001 From: LOLi Date: Sat, 8 Jul 2017 00:45:29 +0200 Subject: [PATCH] Fix chattr_001_pos Commands should be eval()ed if they involve a shell redirection, otherwise we end up writing log_* functions messages to the output. Reviewed-by: Brian Behlendorf Reviewed-by: Giuseppe Di Natale Reviewed-by: George Melikov Signed-off-by: loli10K Closes #6300 Closes #6323 --- .../tests/functional/chattr/chattr_001_pos.ksh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/zfs-tests/tests/functional/chattr/chattr_001_pos.ksh b/tests/zfs-tests/tests/functional/chattr/chattr_001_pos.ksh index 73e4e2e5a..4d66146d7 100755 --- a/tests/zfs-tests/tests/functional/chattr/chattr_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/chattr/chattr_001_pos.ksh @@ -65,11 +65,11 @@ log_must chattr -i $TESTDIR/writable log_must chattr +i $TESTDIR/immutable log_must chattr +a $TESTDIR/append -log_must echo test > $TESTDIR/writable -log_must echo test >> $TESTDIR/writable -log_mustnot echo test > $TESTDIR/immutable -log_mustnot echo test >> $TESTDIR/immutable -log_mustnot echo test > $TESTDIR/append -log_must echo test >> $TESTDIR/append +log_must eval "echo test > $TESTDIR/writable" +log_must eval "echo test >> $TESTDIR/writable" +log_mustnot eval "echo test > $TESTDIR/immutable" +log_mustnot eval "echo test >> $TESTDIR/immutable" +log_mustnot eval "echo test > $TESTDIR/append" +log_must eval "echo test >> $TESTDIR/append" log_pass "chattr works as expected" -- 2.40.0